Support from Acquia helps fund testing for Drupal Acquia logo

Comments

grasmash created an issue. See original summary.

hestenet’s picture

Hm - this makes sense for the very top level of the documentation page - but I'm not sure it makes so much sense for guides themselves.

There was a lot of user research done on the old books hierarchy that said that multiple nesting levels made discoverability much harder. It was a deliberate choice to enforce a flat hierarchy one level deep inside a given guide.

grasmash’s picture

Status: Active » Needs review
Issue tags: +Documentation Initiative
FileSize
4.4 KB
1.63 KB
grasmash’s picture

@hestenet I think you misunderstand. There is already a potentially infinite number of levels of docs. There is a restriction on nesting menu items, but it's easily worked around using entity references that create guides within guides within guides. I'd love to enforce a flatter hierarchy. But, that's a separate issue.

This issue is about exposing in the UI the guides and pages that already exist. For instance, listing all sub guides and pages that belong to the Drupal 8 Community Guide. It's is only a visual change and it only appears where it is applicable.

This change is arguably one of the most important for improving UX. At present, for the Drupal 8 Community Guide, you’d need to open 32 separate guide pages just to learn what pages the child guides contain. That’s not to mention the grandchild guides and so forth.

I'm all for flattening documentation by placing nesting level restrictions, but I don't think we should hide what's there.

See screen shot for the delta.


grasmash’s picture

This also enables us to show guide contents in panel panes:

grasmash’s picture

These changes have been approved by @eojthebrave and by the UX team during the open community meeting.

eojthebrave’s picture

I like this because even though it doesn't address the fact that you can nest things to any arbitrary level it makes any individual landing page appear a bit flatter. e.g.) You get a longer, easier to scan, list of content below whatever point you happen to be at currently. Which hopefully makes it quicker to find the things you're after.

I believe this is at least part of why people in general like docs to have a flatter hierarchy. People would rather have pages with a bit list of links they can scan and parse on their own vs. having to click down ... down ... down ... to uncover the fact that this particular section doesn't even contain what they are looking for.

  • drumm committed a8e9381 on 7.x-3.x, dev
    Issue #2992858 by grasmash: List two levels of guide content in...
drumm’s picture

Status: Needs review » Fixed

This has been deployed with various fixes:

  • Trimmed code that overlapped with other issues, like .left-content styles.
  • Rendering the sub-guide contents from the menu only, without loading additional nodes, and only calling og_menu_get_group_menus() once. To keep page load times from getting much higher.
  • Reduce SASS nesting, to keep generated CSS from getting unnecessarily larger.
  • Only use 2 columns on larger-than-mobile screens.
  • Various improvements for long titles that line wrap - avoid the lines breaking at the column break, less whitespace between lines of the same page, more whitespace between different links.
hansfn’s picture

Great! https://www.drupal.org/docs/8 and https://www.drupal.org/docs/7 are so much more helpful now.

grasmash’s picture

@drumm It doesn't seem like this feature change has taken effect:

+    'block-menu-menu-og-2802989' => TRUE,
+    'block-menu-menu-documentation' => TRUE,
+    'block-menu-menu-og-2734545' => TRUE,
+    'block-menu-menu-og-2827275' => TRUE,

I'm not able to add these panes to the section nodes. They're not listed in the available content.

drumm’s picture

Let’s handle those in #2828874: Design top level landing page for the new documentation system, #2979204: Update bluecheese stlyes and allowed panelizer content for new docs designs or a separate issue. I think the idea was adding those to the top-level page(s?) only, but there wasn’t anything in this issue explaining the change.

grasmash’s picture

Status: Fixed » Needs review
FileSize
201.62 KB

The CSS modifications to the patch make it such that the OG Menu blocks in #2994397: Allow top-level guide menus to be added to sections do not correctly render as two column when inserted into section nodes.

On the dev site, the /documentation landing page looks like this:
Dev image

But on prod, it looks like this:
prod

I suspect this is due to the changes in SASS nesting.

grasmash’s picture

FileSize
1017 bytes

Adding patch to address two column menus on page and section nodes.

drumm’s picture

Project: Drupal.org customizations » Bluecheese
Version: 7.x-3.x-dev » 7.x-2.x-dev
Assigned: Unassigned » drumm
Status: Needs review » Fixed

This was cleaned up and deployed. Only one small change to reduce negative margins, which are often not ideal.

The commit didn’t show up on the issue here because the issue was on the wrong project.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.