Problem/Motivation

The last PhotoSwipe 5-Beta tested was PhotoSwipe 5.0.0.

As anything with name Beta, we had to be ready for breaking changes.

Proposed resolution

Clearly stick to a particular Beta is the only way to have things work till it reaches official stable releases.

For now, it is PhotoSwipe 5.1.7.

Bigger than this might or might not break. Sticking to this very version will do till it is out of Beta.

Remaining tasks

Write patch, review

User interface changes

None, a set and forget.

API changes

None, a set and forget.

Data model changes

None, a set and forget.

CommentFileSizeAuthor
#2 3256023-photoswipe-5.1.7-2.patch46.65 KBgausarts
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gausarts created an issue. See original summary.

gausarts’s picture

gausarts CreditAttribution: gausarts commented
Status: Active » Needs review
FileSize
3256023-photoswipe-5.1.7-2.patch46.65 KB

A few fixes:

  • Converted to ES6 for consistency with library, except 4.x till future releases.
  • Fixed for hard-coded libraries path to support core library finder.

  • gausarts committed fafb025 on 8.x-1.x 
    Issue #3256023 by gausarts: Update to PhotoSwipe 5.1.7
gausarts’s picture

gausarts CreditAttribution: gausarts commented
Status: Needs review » Fixed

Any misses or improvements may follow as usual.

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.