Another issue that popped up while debugging with E_NOTICE enabled concerned the use of the variable $inline in the function theme_biblio_tabular(). Around line 253, $inline is passed as one of the variables to theme 'biblio_format_authors' without being defined beforehand. On my local copy, I have now added an initialization to FALSE just before this call. I am not sure what the original intent was regarding the initialization of this variable. However, it does need to be addressed to eliminate the E_NOTICE warnings.

Cheers!!

Comments

rjerome’s picture

rjerome CreditAttribution: rjerome commented

Hi Lars,

Thanks for those pointers, For what it's worth, these have already been addressed in the 7.x version, I've just never gotten around to fixing up the 6.x trees.

To the best of my knowledge, 7.x runs completely warning free :-) (and under PHP 5.3.x)

Cheers,

Ron.

Lars Toomre’s picture

Lars Toomre CreditAttribution: Lars Toomre commented

Hi Ron,

Good to know that version 7 is without warnings. I have not started yet to look at anything in version 7 other than what I need to do with the core changes to get my own modules transferred.

Would you prefer that I hold off on noting any further D6 NOTICE issues? Or for completeness should they be recorded?

Let me know. Thanks.

Lars

Liam Morland’s picture

Liam Morland
Primary language English
Location Ontario, CA 🇨🇦
CreditAttribution: Liam Morland at University of Waterloo commented
Issue summary: View changes
Status: Active » Closed (outdated)

This version is no longer maintained. If this issue is still relevant to the Drupal 7 version, please re-open and provide details.