autoassignrole_content_profile_settings can result in multiple calls to user_roles which results in a database hit. A static cache can be introduced. Patch attached.

CommentFileSizeAuthor
#3 autoassignrole-hook_content_profile_settings-fix-key.patch519 bytesrecrit
autoassign.patch727 bytesmarcingy

Comments

cyberswat’s picture

cyberswat commented
Status: Needs review » Fixed

http://drupal.org/cvs?commit=305714

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

recrit’s picture

recrit commented
Version: 6.x-1.1 » 6.x-1.x-dev
StatusFileSize
new autoassignrole-hook_content_profile_settings-fix-key.patch519 bytes

the patch above does not work. It changes the settings array key from 'autoassignrole_use' to 'values', therefore, the saved value never gets used since all forms and references look for 'autoassignrole_use'. The attached patch changes it back and is applied to 6.x-1.x-dev

recrit’s picture

recrit commented
Status: Closed (fixed) » Needs review

changing status to needs review

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Category: feature » bug
Status: Needs review » Reviewed & tested by the community

Confirmed, the changes in the first patch above will never work as it changes the array key from 'autoassignrole_use' to 'values'.

The patch in #3 fixes the problem.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Hmm, appears this was already fixed #755308: Content profile settings are not saved