Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Settings set on administration pages of content profile are not saved because of autoassignrole_content_profile_settings() function using wrong key name when setting item in array. This patch fixes that.
Comment | File | Size | Author |
---|---|---|---|
#13 | autoassignrole-755308.patch | 536 bytes | maddentim |
autoassignrole-content-profile-settings.patch | 453 bytes | ahwayakchih | |
Comments
Comment #1
YK85 CreditAttribution: YK85 commentedsubscribing
Comment #2
tamanna-freelancer CreditAttribution: tamanna-freelancer commentedThanks it saved me a lot of time!
Comment #3
cyberswat CreditAttribution: cyberswat commentedneat ... I'll assume that means RTBC and get this committed
Comment #4
cyberswat CreditAttribution: cyberswat commentedhttp://drupal.org/cvs?commit=366834
Comment #6
johnhanley CreditAttribution: johnhanley commentedI just inherited a project that uses Auto Assign Role and was surprised to discover this fatal bug fix isn't part of the latest release. Obviously the patch was applied on May 13, 2010, and the last release is dated May 11, 2010.
When it comes to utilizing "Assign from Path" the module is completely worthless without this fix. Maybe it's part of 6.x-2.0-beta1, but the version doesn't indicate that.
Comment #7
abaddon CreditAttribution: abaddon commentedditto, this should be made into a release, im itching to mark it as active and critical :-)
Comment #8
geoffb CreditAttribution: geoffb commentedJust used Drush to install Auto Assign Role and it installed 6.x-1.2 so saw the save error straight out of the gate.
Took me awhile to find this patch (which I'm assuming will solve the problem), so ditto for me too to roll it into latest release.
Comment #9
delykj CreditAttribution: delykj commented+1 to commit this fix in the latest release
Comment #10
johnhanley CreditAttribution: johnhanley commentedWhy is the status of this issue set to "closed (fixed)"?
Comment #11
maddentim CreditAttribution: maddentim commented@Bacteria Man, unfortunately, this issue lays is the limbo land of when a patch has been committed that fixes the issue, but the patch has not been included in an official release of the module. As is all too often common in drupal, there has not been a release made for this module in 15 months (e.g. signup, gmap). In fact, the patch for this issue was committed just 2 days after the 6.x-1.2 release. There actually look to be a couple important unreleased commits in the queue that you might want to pull into your code.
Comment #12
dparri CreditAttribution: dparri commentedhow can I insert the patch?
I have found these instructions http://drupal.org/node/707484, but unfortunately for me its not enought to understand how to insert AAR patch
Thank you
Comment #13
maddentim CreditAttribution: maddentim commented@dparri,
Unfortunately, looking at the original patch file, it looks it was not made such that the paths might cause you difficult applying it. (It is a diff between autoassignrole.module and autoassignrole/autoassignrole.module. applying it with a "-p0" option should make it work. Regardless, I made a patch file for you from the original commit for your convenience.)
So, if you are using the stock aar module, download my patch file and save it in the AAR module folder. The slightly tricky part is the instructions from here would vary based on the OS of your computer. On a linux machine, from a command line terminal, navigate to your aar module folder with the patch file saved in it. Type:
patch -p0 <autoassignrole-755308.patch
After applying the patch, you could remove the patch file or leave as a reminder to you that you applied a patch. If the patch operation reports errors you will need to troubleshoot the problem. Often it has to do with a mismatch between the path of the file(s) to be patched and the paths specified in the patch file. Or if you have changed the aar module, it may not find what it is expecting in the spot it wants to apply the patch. When they release a new version, you can update and forget about the patch.
The other option is to just use the 6.x-1.x-dev version of the module. This will get you a few more unreleased commits. You should test carefully any of the modifications :)