Problem/Motivation

When using the option, the entities translations labels are not saved.

Proposed resolution

Modify the batch operation to resave all the entity translations.

Issue fork auto_entitylabel-3298772

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

unstatu created an issue. See original summary.

unstatu’s picture

unstatu commented
Version: 8.x-3.x-dev » 8.x-3.0-beta4

unstatu opened merge request !8

unstatu’s picture

unstatu commented

Just noticed that the error was in 8.x-3.0-beta4. Not sure if it's already fixed in the dev branch. Will check.

Anyway, for anyone interested, I have created a MR that will work for beta4: https://git.drupalcode.org/project/auto_entitylabel/-/merge_requests/8

unstatu closed merge request !8

unstatu opened merge request !11

unstatu’s picture

unstatu commented
Version: 8.x-3.0-beta4 » 8.x-3.x-dev
Status: Active » Needs review

I have checked that the bug persists on the version 3. I have updated the MR for this version.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Related issues: +#3243193: Re-save for labels in multiple languages only affects the original language

Seems like this is related: #3243193: Re-save for labels in multiple languages only affects the original language or even similar?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work
dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

Yaiks! I missed that one completely. Thanks for the wake up call @anybody - What do we need to move on?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@dqd thanks, see comment!

liam morland made their first commit to this issue’s fork.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review

Issued raised by comments addressed.

There is one failure on phpunit (next minor). This not caused by the change in this issue.

Has any version of this worked for people? When I have tried it, it does save all the translations but the generated values are all in the site's default language. This may be because the tokens we're using refer to entity references and so the targets of the references are not translated even if the entity itself is.

benstallings’s picture

benstallings commented
Status: Needs review » Reviewed & tested by the community

Apologies, I posted on the wrong issue.

benstallings’s picture

benstallings commented
Status: Reviewed & tested by the community » Needs review
benstallings’s picture

benstallings commented
Status: Needs review » Reviewed & tested by the community

Claude Code says:

Verdict: The logic is correct and well-scoped. The only actionable item for this branch is renaming $translatedEntity → $translated_entity to follow Drupal coding standards.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

It seems to me that the RTBC status is to be set when the code has been reviewed and tested by people, not by an AI.

benstallings’s picture

benstallings commented

I (a person) also reviewed the code. :) But I thought Claude put it better.