There are following 3x Issues at current AMP Version:

1. Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "asset.css.collection_renderer", path: "ajax_response.subscriber
ArgumentCountError: Too few arguments to function Drupal\Core\Asset\CssCollectionRenderer::__construct(), 1 passed in /modules/contrib/amp/src/Asset/AmpCssCollectionRenderer

2. TypeError: Drupal\amp\EventSubscriber\AmpEventSubscriber::onView(): Argument #1 ($event) must be of type Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent

3. Error: Call to undefined function drupal_get_path() in amp_theme_registry_alter() (line 327 of docroot/modules/contrib/amp/amp.module).

Provided Patch solves all of these 3x Issues. The Patch should be compatible with current dev version.

Please integrate it into the latest version

CommentFileSizeAuthor
#3 amp--d10-compatibility--3353999-3.patch2.25 KBflefle
#2 amp--d10-compatibility--3353999-1.patch4.53 KBflefle
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

flefle created an issue. See original summary.

flefle’s picture

flefle CreditAttribution: flefle as a volunteer commented
FileSize
amp--d10-compatibility--3353999-1.patch4.53 KB

Patch solving the 3x Issues.

flefle’s picture

flefle CreditAttribution: flefle as a volunteer commented
FileSize
amp--d10-compatibility--3353999-3.patch2.25 KB

This patch focuses only at:
Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "asset.css.collection_renderer", path: "ajax_response.subscriber
ArgumentCountError: Too few arguments to function Drupal\Core\Asset\CssCollectionRenderer::__construct(), 1 passed in /modules/contrib/amp/src/Asset/AmpCssCollectionRenderer