Closed (fixed)
Project:
AJAX Comments
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
7 Mar 2009 at 21:37 UTC
Updated:
30 Jul 2013 at 08:09 UTC
Jump to comment: Most recent file
Comments
Comment #1
neochief commentedThanks for the patch! Commited to 6.x. You may found changes in latest dev (from March, 8).
Comment #3
jcmarco commentedI have found some issues using Wysiwyg 2.x-dev (with TinyMCE) and AJAX Comments, where the wysiwyg editor is not starting in the comment form.
It is like ajax comments were not re-attaching, or detaching it, to the comment form correctly.
In fact if you click the "Disable rich-text" text added by wysiwyg and again "Enable rich-text" it works fine.
But this also shows that the ajax_comments_remove editors() and ajax_comments_attach_editors() from the ajax_comments.js is not executing the right options with the wysiwyg module.
Comment #4
jcmarco commentedSome more info.
If you open a node with comments, (and the option to have comments in the same windows), and you have the ajax_comments option "Form always expanded" on, then the first open form is right, but if you try to open other comment form replying to an existing comment then it doesn't start wit the wysiwyg editor (in fact is something start because the Disable rich-text is already there, but the rest is not starting right)
In the case you have the "Form always expanded" form off, the when you try to expand the new comment form then that one is already wrongly initialized.
Comment #5
jcmarco commentedWell, testing with ajax_comments 6.x-1.7 it works fine, so last commit from 24th March broke the attachment of wysiwyg editor!
Comment #6
neochief commentedThanks for your investigation, Jose. I'll figure it out.
Comment #7
bluecobalt commentedThis is still happening just as jcmarco described, in the latest 6.x-1.x-dev. Any thoughts yet on how to fix it?
Comment #8
jcmarco commentedFollowing the same actions that Wysiwyg.js with Drupal.behaviors.attachWysiwyg(context) and adding a Drupal.wysiwygDetach($(this), params); before the Drupal.wysiwygAtach($(this), params); in the function ajax_comments_attach_editors(), then the attachment and detachment of new wysiwyg editors work fine, but in same forms when you try to send more comments or a new one, then you get this error:
Comment field is required.
Comment #9
jcmarco commentedI have been testing last AJAX Comment version, and there is still issues with Wysiwyg API.
First time you open comments, (in a new page or following node content) you are able to open the wysiwyg API element
wherever you click on any reply link, even with new comment once you have open the editor in any old comment.
And you can send the first comment, the first time perfectly.
But once you have send any of them, a new one o replying an existing one, then you find some of this two issues:
- the wysiwyg editor it's hung, I mean, the interface is attached but the editor is locked.
- or you see that the wysiwyg editor open the same menu one after the other as you click in a reply link
When you try to send any comment on this situation then you get this error:
Comment field is required.
Comment #10
eyecon-1 commentedExact same issues as #9, above with wysiwyg/tinyMCE and latest dev of AC. Any progress? Anyone have an incantation that works?
Comment #11
SCaV3NG3R commentedsame issue, thanks in advance to whoever can help.
Comment #12
mcload commentedI see the same problem described in comment #9. Wrote a bug report in April to http://drupal.org/node/437110 , but still no solution.
Comment #13
MisterSpeed commentedsubscribing
Comment #14
Kane commentedSubscribing
Comment #15
jeffschulersubscribing
Comment #16
Steven Mansour commentedI cannot get *any* WYSIWYG module to play nice with AJAX Comments either.
Same issues as #9 as well, seen in these screenshots here testing with TinyMCE inside of WYSIWYG module.
1. First comment works fine.
2. After it's posted, clicking on any other reply link breaks the rich editor by adding it multiple times in the text editor box, and not letting me enter any text in it.
Comment #17
mcload commentedIt has been 6 months since first reported. It looks like the problem won't be fixed until somebody contributes a patch.
Comment #18
Steven Mansour commentedSince the title of this thread is titled "wysiwyg compatibility", I have to ask - has anyone successfully enabled this module alongside a rich editor?
Comment #19
zarudnyi commentedsubscribing
Comment #20
tonyoconnell commentedsubscribe
Comment #21
Dr Jay commentedsubscribing
Comment #22
gausarts commentedSubscribing. Thanks
Comment #23
Equinger commentedThis is a great module. It was working fine for me with FCKEditor (not in WYSIWYG API). Now I switched to WYSIWYG cause there are so many more nice add-ons, but this module still doesn't work w/ WYSIWYG. This would be great!
Subscribing.
Comment #24
lperalta commentedSolution for #9 comming up!
I had the same problem and after 1 work day looking into it i found out the following:
1) If my users are assigned to more than one WYSIWYG profile, then 2 or more radios will appear bellow the comment/reply form to switch between profiles:
In this case, the patch commited in the first post works, where $('#comment-form input.wysiwyg-processed:checked') will trigger the selected radio.
2) If my users are assigned to only one WYSIWYG profile OR if i'm using the Better Formats module to disable the "show format selection" option, then instead of the radios an empty div will appear with the exact same css classes that the radios would have.
Here, if you look at wysiwyg.js you'll find out this:
where the editor is attached if a radio OR a div had been found.
so.. to get all the AJAX comments working with only one profile without JS errors i did the following in ajax_comments.js:
@ ajax_comments.js, lines 458 and 477
PS: I don't know how to do a patch to attach here :p and since i hate to change my core, please do one :)
Comment #25
Fidelix commentedSubscribing!
Comment #26
dddave commentedUpgrading priority as wysiwyg and better formats are darn important modules nowadays.
If somebody could code a patch this would be instantly gratified with loads of karma.
http://drupal.org/patch/create
Comment #27
rjbrown99 commentedThanks to everyone for providing feedback for this issue. I'd like to help move this along, but I'll need a bit of feedback first.
1) There are patches associated with the original issue post as well as with #8. The original patch has been committed to the -dev branch back in March.
2) The patch in #8 has not yet been committed. Has anyone tried this with the -dev branch? Did it work?
3) The feedback in #24 seems to indicate that their approach to make this work was to add another selector to the ajax_comments_attach_editors() function in ajax_comments.js. Has anyone tried this with the -dev branch? Did it work?
I'd like a bit of feedback if possible, specifically if either #8 or #24 helps to solve the wysiwyg issue. Again please make sure to do any testing against -dev as it contains a number of bugfixes above 1.8. I'd like to add the fix for this to 1.9 if you all are so kind as to provide feedback. Thanks.
Comment #28
Fidelix commentedI tried #0, #8 and #24.
#8 made no difference in my tests, while #0 and #8 absolutely did.
The comment gets sent, however, no feedback of that is given, the page does not scroll to the new comment and the comments div is not updated on the fly.
I can only see the comment after reloading the page.
Also, the comment textfield (tinymce) is not emptied.
It is still unusable, but i believe we are in the right path.
Comment #29
yngens commentedsubscribe
Comment #30
roadsideok commentedsubscribe
Comment #31
W.M. commented#24
Tested and works fine as it is described by lperalta
I have just verified this using:
AJAX Comments 6.x-1.8
Wysiwyg 6.x-2.2
TinyMCE 3.3.9.2
Drupal core 6.20
We need to verify this also by using latest dev module of Wysiwyg, AJAX Comments, latest TinyMCE and other Wysiwyg editors.
Comment #32
W.M. commentedI have applied the patch at #24. It works fine. The WYSIWYG editor gets loaded as it should. However, if the visitor clicks "Disable rich-text" and wants to reload the WYSIWYG editor again, he cannot. Clicking "Enable rich-text" doesn't reload the editor, once it was manually disabled.
Comment #33
hanoiisubscribe
Comment #34
spaik commentedWhen I added comment with NicEdit -> error "Comment field is empty".
But if, before a comment, switch to the default editor, and make a comment, then comment added.
p.s. sorry for my bad English.
Comment #35
droopy commentedsubscribe
Comment #36
igorik commentedsubscribe, it looks that this module is not very well maintained, 7 month from last author reply and nothing new about it.
As ddave wrote, wysiwyg and better formats are really necessary modules and if this doesn't work with them very well, it is not good.
IMHO this really could be major issue.
Comment #37
rjbrown99 commentedIt depends on what you consider well maintained. I don't think that any of the current module maintainers have a need for this functionality, hence we aren't dedicating time to work on it. If you or someone else in the community has a need for this, you are welcome to develop the code for the fix (or sponsor someone to do it) and we will review it and commit it for the benefit of anyone else who might want to use this feature.
Comment #38
william.lai commentedHi, drupal 7's ajax comment have similar problem with wysiwyg module. it doesn't detach the ckeditor when submit. is there any patch for drupal 7 for this problem? As ajax comment in drupal 7 is using ajax_command, how do we detach the ckeditor before it submit the ajax callback.
Thanks.
Comment #39
Fidelix commentedI ask the same for TinyMCE (from the WYSIWYG module)
Comment #40
Aurochs commentedSame here for TinyMCE +WYSIWYG+AJAX
Comment #41
Aurochs commentedJust uninstalled wysiwyg and added TinyMCE by hand via , copied settings from my Tiny Tiny MCE module config on D6 site from which i am moving to D7.
With jquery.tinymce.js it works but after posting a comment TinyMCE unsets. After reloading page its here again.
If i use standard tiny_mce.js its not posted at all, failing validation with error saying that the form is empty.
So i guess its not wysiwyg but editors uncompatability?
I use 7.x-dev Ajax Comments and TinyMCE 3.3.9.2
I also tried TinyMCE 3.4.7 jQuery package - same result
So finally what i did is i excluded TinyMCE from comments with below code in to let ajax comments work and i am waiting for updates and pin all my hopes on the project maintainers andypost + acouch and all community to fix the problem...and complete the port to d7.
Thank you in advance\
unfo i have no knowledge of php to try to help
PS = here's what i did:
Comment #42
acouch commentedThis may also fix the issue #356480: Lazy-load editors
Comment #43
Aurochs commentedhurray!!!! tinytnymce works with latest dev version for ajax comments!!! thank you, wysiwyg devs!
Comment #44
Aurochs commentedBUT after posting i have default avatar and my avatar updates on next page load... hmm
Comment #45
acouch commented@Aurochs, is your avatar issue fixed? See #1352734: Incorrect user image / avatar being displayed
Comment #46
mototribe commentedThis is still not working for me (using WYSIWYG 7.x-2.1, TinyMCE 3.5, Ajax_comments 7.x-1.0-alpha1).
I have the comment form shown on the node page.
When I submit a comment I get an error "Comment field is required."
When I edit an existing comment the comment doesn't get updated, it just shows the unchanged comment.
Comment #47
JohnnyW commentedI was using Drupal 6.26 with Ajax Comments version 6.x-1.8 and couldn't type in WYSIWYG Ckeditor rich text editor -- I could see the rich text editor but I couldn't type in it.
BUT #24 fixed the problem for me :)
THANKS!!!
Comment #48
dddave commented*sigh*
Comment #49
mermemladeK commentedHey rjbrown #37, you said the current developers do not need this module anymore. Is it because there is another module with similar functionality? Thank you. Anyway I'm going to subscribe to this thread just in case.
Comment #50
muschpusch commentedI just tested the following setup successfully:
wysiwyg - dev
ckeditor - version 4.1.0.80c139aa
ajax-comments - dev
Please let me know if you any problems!