Broken responsive menu [#2717819]

After upgrading to latest dev (d0eae7d4217dd1653767bbd77c8d3a44f0e8c0ee) which include path from #2442271: Missing Account Links with Mobile responsive menu didn't show up.

This is caused by this line:

$responsivemenu = array_merge($responsivemenu, $content['account']);

What we want to do is to reverse the arguments, because now $content['account'] is overriding $responsivemenu['#wrapper_attributes'] to array('id' => 'admin-menu-account') when it should be array('id' => 'admin-menu-menu-responsive')

Maybe it would be better to only include $content['account']['account'] and $content['account']['logout'] directly, or use element_children() to find menu links.

But I have switch the arguments for now, just to get something working.

Comment	File	Size	Author
#2	adminimal_admin_menu-broken-responsive-menu-2717819-2.patch	654 bytes	logaritmisk
#2	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 CI error

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

3 May 2016 at 07:59

logaritmisk created an issue. See original summary.

Comment #2

logaritmisk CreditAttribution: logaritmisk commented 3 May 2016 at 08:00

Status:

Active

» Needs review

File	Size
adminimal_admin_menu-broken-responsive-menu-2717819-2.patch	654 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 CI error

Attach patch

Comment #3

3 May 2016 at 08:03

Status:

Needs review

» Needs work

The last submitted patch, 2: adminimal_admin_menu-broken-responsive-menu-2717819-2.patch, failed testing.

Comment #4

Christopher Riley CreditAttribution: Christopher Riley commented 12 November 2016 at 19:37

I thought I would test out the theme and therefore the recommended module for it (this one). Like a typical user I enabled things and ran into the duplicate menu issue and fixed it then enabled the responsive advanced setting and it wasn't until I applied this patch that things work as intended. This should really be applied right away to the code.

Thanks for the patch.