Problem/Motivation
Drupal 10 will be released December 2022, and we need to deal with some issues, before cloning the 3.x branch into 4.x, for Drupal 10.
Proposed resolution
Give the 3.x issues the necessary attention, to prepare the 4.x branch code base for Drupal 10.
Remaining tasks
Issues that needs to be addressed before a D10 release, or at least have a good path forward. Release 4.x branch for Drupal 10 when Blockers issues are done
Blockers
- #3273375: CSS has unnecessary duplicated rules with RTL selector
- #3256597: Replace deprecated library core/jquery.once with core/once per D.O. Issue #3158256
Top priorities
Add top priorities here
Non blockers
Add non-blockers here
API changes
Data model changes
Issue fork admin_toolbar-3315478
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
romainj commentedComment #3
ressaUpdating link to get title automatically.
Comment #5
ressaAdding related issues.
Comment #6
ressaTo help prioritize the issues, I have added sub-sections for issues, and added #3256597: Replace deprecated library core/jquery.once with core/once per D.O. Issue #3158256 under "Blockers", since that's what that issue looks like to me. Feel free to move it, if it's not correct.
This way, we can focus on fixing and testing the most important issues, to get them ready first. Inspiration found in #3292217: [meta] Priorities for 2022-12-07 release of Drupal 7.
An observation: Since Admin Toolbar is not ready in advance for the Drupal 10, it can hinder users from starting new projects in Drupal 10, testing patches for Drupal 10, etc. See for example https://www.drupal.org/forum/support/before-you-start/2022-11-02/new-web....
Comment #7
ressaFixing wrong link.
Comment #8
gambryCurrent patch on #3285981: Automated Drupal 10 compatibility fixes still supports Drupal 8 (^8.8.0). With the changes coming from #3256597: Replace deprecated library core/jquery.once with core/once per D.O. Issue #3158256 the minimum supported version will be 9.2.0 (when core/once has been created).
I'm confident there are no Drupal 8 installations around, but just to be safe I'd say the core minimum version should be updated accordingly if #3256597: Replace deprecated library core/jquery.once with core/once per D.O. Issue #3158256 lands first.
Comment #9
gambryAlthough the general understanding in #3256597: Replace deprecated library core/jquery.once with core/once per D.O. Issue #3158256 is a major version bump is not needed.
Neither is needed for D10 compatibility. So this issue should not block the other two.
Comment #10
jcnventura@gambry Not sure where you get the idea that there are no Drupal 8 installations around, when there are still at least 119K of them , about half of the total number of D9 sites. Drupal 8 has about 14% of all Drupal installs, to D9's 30% of the total: https://www.drupal.org/project/usage/drupal
Comment #11
jcnventuraChanging status, as there's nothing needing work here.
Comment #12
gambryI was being sarcastic @jcnventura, since it has been EOL for one year now.
I should have put a "😉".
Comment #13
fgmNot sure why 3.2.1 is not marked as D10-compatible, while 3.1.1 is, but this seems to be the best issue match for that problem. Do we really want to block 3.2.x for D10 and force 4.x, while retaining 3.1.x for D10 too ?
Comment #14
jcnventuraD10 support in 3.1.1 was a mistake that if it was possible to revert should be. The decision on whether 3.x or 4.x will be the D10 version is a
bit left to the maintainers.
Pros and cons for 4.x being the D10 version:
Pros: Allowing the thousands of D8 sites to be have a supported version that is not forever 3.2.2, 3.2.3, 3.2.4, etc, etc. (and having to manage a 3.2.x branch)
Cons: Anyone on Drupal 10 doing "composer require drupal/admin_toolbar:^3" will get 3.1.1 installed.
Comment #15
romainj commentedAs of berdir comment https://www.drupal.org/project/admin_toolbar/issues/3256597#comment-1475... I think that we will go for a 3.3.x branch for D9-D10 compatibility. The 3.2.X branch could receive security release.
Comment #16
romainj commentedComment #17
jcnventuraOK. That's a good choice.. Please note that in git repo terms, you don't have to create a 3.3.x branch, but one of these days you might need to create a 3.2.x branch, if it ever becomes aparent that you need to apply a security patch to whatever is the latest 3.2.x tag.
However, creating that branch can be postponed for later, and easily done by:
Comment #18
jcnventura3.3.0 is out, so this can now be closed.
Comment #19
ressaIt's so great to have this indispensable site building tool ready for drupal 10, thanks everyone!
Comment #21
romainj commented