Problem/Motivation

Currently this packages limits installations to Drupal 8.8 through 9.x, which prevents the module from being installed on a Drupal 10 installation, without aliasing Drupal Core and relate packages as a Drupal 9 version.

Steps to reproduce

  • Require drupal/admin_toolbar in a Drupal 10 project with composer without aliasing Drupal 10, or
    • Alias Drupal Core and related modules at Drupal 9.x (pick your version), and subsequently attempt to enable the module.

Proposed resolution

Add Drupal 10 to composer.json and add ^10 to each module's .info.yml file's "core_version_requirement" parameter.

CommentFileSizeAuthor
#16 interdiff_2_16.txt3.84 KBjheinon_finland
#16 16-3256600-deprecate-code.patch2 KBjheinon_finland
#2 3256600-drupal-10-compatibility.patch2.86 KBlisa.rae

Issue fork admin_toolbar-3256600

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lhridley created an issue. See original summary.

lisa.rae’s picture

lisa.rae commented
StatusFileSize
new 3256600-drupal-10-compatibility.patch2.86 KB
lisa.rae’s picture

lisa.rae commented
Assigned: lisa.rae » Unassigned
Status: Active » Needs review

ressa made their first commit to this issue’s fork.

ressa opened merge request !18

ressa’s picture

ressa
he/him
commented

Thanks @lhridley, I just ran into this blocker, trying to install Admin Toolbar in Drupal 10 with the freshly released Drush 11 running PHP 8.1. It feels very futuristic :)

I have re-rolled your excellent patch in Gitlab, in order to allow cloning directly from that repo, for testing, I hope it's all right. It seems to work fine, and after cloning and checking out the right branch from the Merge Request page, I can install all the modules just fine in Drupal 10.

It would be great to get this committed to dev, and make it available for Drupal 10.

ressa’s picture

ressa
he/him
commented

The Extra Tools Drupal logo was missing (upper left corner) so I added Drupal 10 to the style for Drupal 9, for now. It should probably be added to a To Do list, to update if and when Drupal 10 gets its own logo.

romainj’s picture

romainj commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jcnventura’s picture

jcnventura
Primary language English
commented

As per https://www.drupal.org/node/3158256, the core/once library was added in Drupal 9.2. This means this module is no longer compatible with Drupal 8.8, and as such the information in admin_toolbar.info.yml needs to be updated.

Please reopen this, and correct the information in these info.yml files.

At this moment, the drupal/core requirement in composer.json is not needed (it is filled by the core_version_requirement information from the info file), so it would be better to remove that from composer.json to make sure they do not drift apart.

paulocs made their first commit to this issue’s fork.

paulocs opened merge request !22

jcnventura’s picture

jcnventura
Primary language English
commented

Please reopen this, only maintainers can do so.

The best way to fix this would be:
* Create 4.x branch from current state, and add minimum requirement of Drupal core 9.2, as core/once was added in that version.
* In the 3.x branch, revert this change so that any future security issue for the 3.x branch is still compatible with Drupal < 9.2.

Also, remove the duplicate drupal/core requirement in composer.json, since that is automatically added by the drupal.org packagist from the information in the .info.yml file, and it is a lot easier to maintain if this information is in only one place.

merilainen’s picture

merilainen commented

What about deprecated code? There are at least two problems which upgrade status reports:

Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

in SearchLinks.php and ExtraLinks.php

jheinon_finland’s picture

jheinon_finland commented
StatusFileSize
new 16-3256600-deprecate-code.patch2 KB
new interdiff_2_16.txt3.84 KB

As mErilainen stated above, there really was some deprecated code in the aforementioned classes SearchLinks.php and ExtraLinks.php.

In this, the change for adding the missing accessCheck is included as well as the interdiff file between the original patch and the newer patch.

hkirsman’s picture

hkirsman commented

D10 support has been added already to 3.x dev version. The last commit seems to be done in https://www.drupal.org/project/admin_toolbar/issues/3338408

This particular issue seems done.

dydave closed merge request !22