Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.
Here is the summary of running ESLint on this module JS:
✖ 6 problems (6 errors, 0 warnings)
Attached is the full list of errors found by ESLint.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | admin_menu-fix_eslint_erros_warnings-2490318-3.patch | 41.61 KB | grimreaper |
| #1 | fix-eslint-errors-1.patch | 36.87 KB | rteijeiro |
| fix-eslint-errors.patch | 1.08 KB | rteijeiro | |
| admin_menu-eslint-output.txt | 478 bytes | rteijeiro |
Comments
Comment #1
rteijeiro commentedSorry, forgot a few files. There is still a rule remaining. Not sure if we can remove the console.log statement:
Comment #3
grimreaperHello,
Thanks for the patch. I also wander how we can handle the console.log, as it is for debug purpose maybe we can leave it.
I add warnings for missing @param and @returns
I fixed them in my patch. But I wonder if I am right in the type and description.
Thanks for the review.
Comment #4
hongpong commentedComment #5
thallesThis module has been deprecated for Drupal 8.
For Drupal 8: the Admin Toolbar provides an experience similar to admin_menu with the core toolbar.
Comment #6
thalles