Handling of user login/register/password pages and maintenance mode doesn't seem right [#997518]

There seems to be an issue with the user/* pages like user/login and user/register etc.
They are always displayed using the maintenance-page.tpl.php so they don't have the blocks they should have (even when the site is not in offline mode).

The problem is that as far as I can tell (decent doco seems to be lacking in this area) maintenance mode and it's related MAINTENANCE_MODE constant is not the same thing as the site_offline variable, which is set at admin/settings/site-maintenance.

The MAINTENANCE_MODE constant is only used in relation to the install.php and update.php processes.
Outside of those the MAINTENANCE_MODE constant is not used.

Site maintenance mode, which is what you refer to in your post at http://adaptivethemes.com/how-to-theme-the-user-login-page-in-maintenanc... is related to variable_get('site_offline', 0); as opposed to MAINTENANCE_MODE.

In addition, the code only checks that arg(0) == user, which also includes user/register and user/password.

This patch addresses these 2 points.
Technically they could be in separate issues if you prefer but thy are both small and related.

Comment	File	Size	Author
	adaptivetheme-maintenance_page.patch	1.99 KB	rooby

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rooby CreditAttribution: rooby commented 14 December 2010 at 04:08

+++ adaptivetheme/template.php	14 Dec 2010 03:34:16 -0000
@@ -16,7 +16,7 @@ if (db_is_active()) {
@@ -30,4 +30,4 @@ if (db_is_active()) {

@@ -30,4 +30,4 @@ if (db_is_active()) {
   if (theme_get_setting('block_edit_links')) {
     drupal_add_css(drupal_get_path('theme', 'adaptivetheme') .'/css/edit-links.css', 'theme');
   }
-}
\ No newline at end of file
+}

Also, I have no idea why this is in here. I couldn't get rid of it.

Powered by Dreditor.