php notices [#993094]

just enabled the 2.x dev and got a boatload of php notices:

    * notice: Undefined index: style in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 106.
    * notice: Undefined index: node in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.preprocess-page.inc on line 115.
    * notice: Trying to get property of non-object in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.preprocess-page.inc on line 115.
    * notice: Undefined variable: layout_settings in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/templates/page.tpl.php on line 97.
    * notice: Undefined variable: skip_nav_class in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/templates/page.tpl.php on line 103.
    * notice: Undefined variable: active_regions in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-js.inc on line 29.
    * notice: Undefined variable: active_regions in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-js.inc on line 32.
    * notice: Undefined variable: article_id in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/templates/node.tpl.php on line 55.
    * notice: Undefined variable: unpublished in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/templates/node.tpl.php on line 60.
    * notice: Undefined variable: article_id in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/templates/node.tpl.php on line 55.
    * notice: Undefined variable: unpublished in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/templates/node.tpl.php on line 60.
    * notice: Undefined variable: class in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 195.
    * notice: Undefined variable: class in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 218.
    * notice: Undefined variable: class in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 195.
    * notice: Undefined variable: class in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 218.
    * notice: Undefined variable: class in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 195.
    * notice: Undefined variable: class in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 218.
    * notice: Undefined variable: class in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 195.
    * notice: Undefined variable: class in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 218.
    * notice: Undefined variable: class in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 195.
    * notice: Undefined variable: class in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc on line 218.
    * notice: Undefined variable: block_module_delta in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/templates/block.tpl.php on line 32.
    * notice: Undefined variable: block_module_delta in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/templates/block.tpl.php on line 32.

I'll try to roll a patch tomorrow but i wanted to post this in the meantime.

Comment	File	Size	Author
#4	993094.patch	988 bytes	jwilson3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

WorldFallz CreditAttribution: WorldFallz commented 9 December 2010 at 01:20

And a bunch more on the theme setting page (even after saving):

    * notice: Undefined variable: output in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 150.
    * notice: Undefined index: equalize_leaderboard in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined index: equalize_header in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined index: equalize_secondary-content in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined index: equalize_content-top in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined index: equalize_content-bottom in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined index: equalize_tertiary-content in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined index: equalize_footer in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined variable: output in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 150.
    * notice: Undefined index: equalize_leaderboard in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined index: equalize_header in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined index: equalize_secondary-content in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined index: equalize_content-top in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined index: equalize_content-bottom in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined index: equalize_tertiary-content in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined index: equalize_footer in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 690.
    * notice: Undefined variable: output in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 150.
    * notice: Undefined variable: output in /home/public_html/sites/all/themes/adaptivetheme/adaptivetheme/theme-settings.php on line 150.

Comment #2

WorldFallz CreditAttribution: WorldFallz commented 9 December 2010 at 01:29

Not sure what all the theme_get_setting('cleanup_ calls are for but that seems to be where the problem with tpl.php variables is caused.

Comment #3

Jeff Burnz CreditAttribution: Jeff Burnz commented 12 December 2010 at 11:50

This could be cockup on my part due to recent commits, I will need to check, hopefully I'll have time in the next week or so to looking into this. I'm kinda on holiday at the moment until early Jan but I'll make an effort :)

Comment #4

jwilson3

English

Ecuador

CreditAttribution: jwilson3 commented 3 January 2011 at 18:29

File	Size
993094.patch	988 bytes

Here is a small patch to fix the first error (Undefined index: style) which i encountered on 6.x-2.2.

This was the only error I encountered on 6.x-2.2 while developing with PHP error_reporting set to E_ALL | E_STRICT.

Comment #5

jwilson3

English

Ecuador

CreditAttribution: jwilson3 commented 5 January 2011 at 14:50

Status:

Active

» Needs review

Comment #6

asb CreditAttribution: asb commented 24 January 2011 at 17:26

Im experiencing similar issues with a freshly set up subtheme of 6.x-3.x-dev, the watchdog log is flooded with errors like

...
Notice: Undefined index: style in adaptivetheme_button() (line 41 of /var/www/drupal/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc).
...
Notice: Undefined variable: secondary_menu in include() (line 156 of /var/www/drupal/sites/all/themes/adaptivetheme/adaptivetheme/templates/page.tpl.php).
...
Notice: Undefined variable: toggle_label in include() (line 136 of /var/www/drupal/sites/all/themes/adaptivetheme/adaptivetheme/templates/page.tpl.php)
...
Notice: Undefined index: class in adaptivetheme_links() (line 125 of /var/www/drupal/sites/all/themes/adaptivetheme/adaptivetheme/inc/template.theme-overrides.inc).
...

When setting up the subtheme, I followed the instructions from http://adaptivethemes.com/documentation/setting-up-your-6x-2x-subtheme (which might not fully apply to the 3.x branch). I assume that 6.x-3.x-dev is real development stuff and shouldn't be used for production?

Greetings, -asb

Comment #7

Macronomicus CreditAttribution: Macronomicus commented 18 October 2011 at 23:46

Version:

6.x-2.x-dev

» 6.x-3.x-dev

Yea I just upgraded to php 5.2 and now all my sites based on 3.x-dev have this issue.

Comment #8

Macronomicus CreditAttribution: Macronomicus commented 19 October 2011 at 02:20

Actually it was an upgrade from php 5.2.6 to 5.2.10 ... I upgraded to Lucid which comes with 5.3 but I pinned php back to 5.2.10 lol apparently I needed to go back just a touch more.