Closed (fixed)
Project:
Acquia DAM
Version:
1.1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Dec 2025 at 06:51 UTC
Updated:
29 Jan 2026 at 12:43 UTC
Jump to comment: Most recent
Fix failing Drupal Canvas test. See https://git.drupalcode.org/project/acquia_dam/-/jobs/7677806#L101.
This is due to the hook name change in Canvas 1.0.1 release, see.
Also fix failing Media: Acquia DAM tests.
Update the acquia_dam_module_implements_alter as per change record - https://www.drupal.org/node/3496788 for Drupal Canvas and Media: Acquia DAM modules.
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
rajeshreeputraComment #5
rajeshreeputraComment #6
rajeshreeputraCR link - https://www.drupal.org/node/3496788
Comment #7
rajeshreeputraComment #8
rajeshreeputraComment #9
ankitv18 commentedLooks good, moving into RTBC.
Question:
Why we are implementing hook for media_acquiadam as this module is obsolete? If media_acquiadam changes are required then please update the description.
Comment #10
rajeshreeputraAs per change record - https://www.drupal.org/node/3496788, now the hook_module_implements_alter must be implemented using the new style.
Comment #11
rajeshreeputraComment #13
amangrover90 commentedComment #15
vishalkhode commentedIdeally CI should fail, but if CI is passing, then maybe something is introduced in latest release of 11.1.x is not causing module installation to fail. This needs to be manually tests with older release of 11.1.x to confirm, if we can use
OrderAfterclass.Comment #16
rajeshreeputraNo need as Canvas only works with Drupal 11.2.x and above, see.
Comment #18
vishalkhode commentedThe Canvas requires Drupal Core ^11.2 from the day 1, but Acquia DAM supports Drupal Core ^9.5 and above and the module installation was failing in lower version of Drupal. That's why the comment was added here.
Comment #21
rajeshreeputraMR merged!
Comment #24
wim leersThis issue's CR:
This is wrong. See https://www.drupal.org/node/3561450.
The deprecated hook continued to work. A BC layer is in place. All that happened was deprecation errors appeared. Citing the code in Canvas:
Comment #25
rajeshreeputraUpdated:
In Drupal Canvas module
hook_storage_prop_shape_alterhas been deprecated and new hook added tohook_canvas_storable_prop_shape_alterwith the same signature.