Support from Acquia helps fund testing for Drupal Acquia logo

Comments

quicksketch’s picture

Yes I have plans to port FileField Sources to D7 but I haven't yet started it. The APIs in D7 have continued to change drastically, I'm postponing any further ports until it stabilizes (since all the modules I have ported have since broken because of the changes).

quicksketch’s picture

Status: Active » Postponed
effulgentsia’s picture

Hey quicksketch, I'd like to try to lobby you (and other FileField Sources developers/users) to consider making http://drupal.org/project/media the D7 solution for the same use-cases, and to spend time making Media better, rather than porting Filefield Sources to D7. You can see my quick pitch about this at the end of #911130-4: Implement the new file_usage API. Please feel free to follow-up on this issue or contact me personally to discuss this more, but I'm hoping that if we do it right, then everyone can benefit from a single robust solution over fragmented and highly overlapping ones.

Boris Mann’s picture

@effulgentsia - is there a media_sources project already started, or equivalent? End user wise, filefield_sources is a small, simple module that does only one thing, and does it well.

I understand the desire to make an overarching media framework for Drupal. The fact that there is no end user bits yet make me think that all the bits that media is trying to tackle is going to be hard to pull off in one bite.

Perhaps filefield_sources could be media compatible, once media actually ships / has hooks to plug into?

Isostar’s picture

+1 subscribe

effulgentsia’s picture

is there a media_sources project already started, or equivalent?

Yes, D7's Media project includes a media_internet.module for entering a URL, and depending on the enabled provider modules, doing something with that URL. An example of a provider module is Media: Youtube, where the URL is mapped to a youtube stream wrapper, and then when it's time to display it, it's rendered as an EMBED. If no provider "claims" the URL, then media_internet.module copies the file from the URL to Drupal's files folder, so this can be used for generic remote images.

filefield_sources is a small, simple module that does only one thing, and does it well.

It's been a while since I played with filefield_sources, but last time I did, it did 2 things very well. One was to transfer a file from a URL to Drupal's files folder, and the other was to be able to have the same file re-used across different file fields. Both excellent things to be done. The media module does both of these too, though for a media field rather than a file field. It's particularly the re-use part that I think is a better fit for media module than a D7 filefield_sources module, because there's all sorts of UI issues that come up when trying to effectively re-use a file entity across multiple pieces of content (including things like presenting a "library" of available files), which is being dealt with in the Media project.

I'm not opposed to parallel experimentation, or if filefield_sources has a useful, lightweight role to play for people not wanting all of Media module. But I hope it's possible to make Media module sufficiently lightweight to be attractive for all use-cases where D6 filefield_sources has been used.

davidzz’s picture

I'ld like to suggest we keep FileField Sources available for D7. Media is a very useful module with lots of functionalities, but for a lot of sites it is not really appropriate to use such a large scale product with a complex UI (and an oftentimes unnecessary "library") when all that's required is to transfer files from an URL to Drupal - media or not.

I would strongly encourage a D7 port, and am willing to help whenever necessary (though I don't know much about module development).

quicksketch’s picture

I am planning on eventually porting FileField Sources to Drupal 7, considering I specifically wrote functionality into the D7 File module to make FileField Sources a more useful tool that can be added to any #managed_file element anywhere in Drupal, not just file fields added through the Field module (meaning you wouldn't even have to have "entities" at all to use it). This means using it in places like setting the default image for an Image field or other places where you're not using a D7 Field at all.

In any case though, I'm not going to spend time working on this until Drupal 7 actually comes out. It only takes me a few hours to port a module but endless frustrations keeping up with D7's constant API breakage.

binford2k’s picture

I played around with media and saw a lot more errors than I like. I vote for porting this module.

binford2k’s picture

An RC is out. They're not changing the API anymore.

steinmb’s picture

Subscribing

thekevinday’s picture

subscribe

nateB’s picture

Subscribing.

igorik’s picture

subscribe, RC4 is out, and January 5th Drupal 7 will be released

didox’s picture

Subscribing

nicolas.antoniazzi’s picture

subscribing. D7 is released. I'm with you :)

Scott J’s picture

Oh yeah! Definitely need a browser for filefield. There aren't any other D7 browsers besides media_browser are there?

didox’s picture

TinyBrowser ?

Scott J’s picture

Thanks, but TinyBrowser is inline for wysiwyg only, not for filefield.

LDawg’s picture

Gogogo quicksketch :P

subscribed

tsvenson’s picture

Following

mlncn’s picture

Status: Postponed » Active

Marking this active, as Drupal 7.0 is out :-)

denniemans’s picture

subscribe

georgedamonkey’s picture

subscribe

ClaudeS-1’s picture

subscribe

BenK’s picture

Subscribe

bfroehle’s picture

~

patrickharris’s picture

subscribe!

W32’s picture

Subscribe.
I want this version!

Jon Betts’s picture

Yes, this is pretty critical for business users (clients). Thanks!

scroogie’s picture

Subscribing.

nicholasThompson’s picture

Status: Active » Needs work
FileSize
29.46 KB

I have made a start. This is a patch against HEAD. this doesn't "work" yet - but it at least installs and provides the expected form options ;)

igorik’s picture

Status: Needs work » Needs review
nicholasThompson’s picture

Status: Needs review » Needs work

I left it on "needs work" as it needs work, it's not ready yet (doesn't work properly/reliably). :)

rodrigoaguilera’s picture

suscribe

Tebb’s picture

Subscribing.

jthomasbailey’s picture

Subscribing

sylvain_a’s picture

Suscribing

Kama’s picture

Subscribing

Tebb’s picture

Title: D7 version » FileField Sources: D7 version

Issue title changes to make module name visible in Dashboard->Your Posts

mortendk’s picture

+1

antiorario’s picture

subscribing

wayfarer_boy’s picture

subscribing - I tried working with coder module using the D6 version of filefield_sources, and couldn't make head nor tail of it. Will give it another go with the patched version but I'm not confident with jobs like this. quicksketch's 'a few hours' of development are 'a few weeks' for me!

This is one in a long line of must-have modules not yet ported to D7. Looking forward to testing updates.

W32’s picture

we all waiting D7 version, but ... :(

cherokeedude’s picture

Component: Code » Documentation
Priority: Normal » Major

Subscribing

bfroehle’s picture

Component: Documentation » Code
Priority: Major » Normal

Component and priority were inadvertently changed in the previous post.

mortendk’s picture

alright i dont have the abilities or time to figure this out, so instead im in for a chip in to get this unicorn into the air, but i have deadlines & clients that are paying.

So I will throw the first 300€ into the pool to get this module done, if that can get thou mighty quicksketch (or another) to rock out a drupal7 version. so we can get imce to work with the filefields. :)

good_man’s picture

I haven't used this module before, just subscribing to see who'll get the bounty :)

P.S. I might jump in if the bounty goes higher :D

antiorario’s picture

Sorry to rain on everyone's parade, but the patch at #32 adds the form elements to the field settings, not to the widget settings for the specific node type.

Instead of adding the new form elements to the edit-field fieldset, it should add them to the edit-instance fieldset. I'll see if I can find a way to make that work (I'm just starting on Drupal 7 development, and it's like learning a whole new language).

Also, if you apply the patch you might want to delete line 67 of the resulting .module file, which contains a dpm($form); that breaks Drupal if you don't have Devel module installed.

good_man’s picture

yeah it's not a direct patch, field field from CCK in D6 changed so much in D7, so whoever will do the patch must first know the new field/entity thing in D7.

antiorario’s picture

That's the same conclusion I came to earlier, after going through the code. Which is also why I'm studying the new APIs—something I would have had to do anyway, so…

bfroehle’s picture

This is as far as I can go with it. I've cleaned up the settings and moved them into the instances pane.

I changed how the settings are stored in the $instance['settings'] array -- this might be unfortunate for upgrading -- but I didn't want to go back and fix it.
(before things were stored, I think, like
filefield_sources => array( ..enabled sources.. )
source_attach => (it's settings)

Now I think I've taken all of those and shoved them into another array keyed by filefield_sources. Oh well.

What works: the settings pages, links on the file widget.

What doesn't work: everything else.

Difficulties: the file upload widget isn't putting things in a div anymore. Or else I've attached to #process too far down the render array. This makes the JS complicated.

attiks’s picture

subscribing

l33tdawg’s picture

subscribing

Agence Web CoherActio’s picture

subscribing

perandre’s picture

pubSUBhubbub!

joostvdl’s picture

subscribe

knaffles’s picture

subscribe

bennash’s picture

subscribe

aristeides’s picture

subscribing

Damir’s picture

subscribing

jthomasbailey’s picture

+1 making this a part of the Media module

OFF’s picture

D7 Delayed

W32’s picture

D7 Delayed

What ?

mouize’s picture

Subscribing !

fender-dupe’s picture

come on people, we need this for D7, this is an amazing module

TimG1’s picture

Subscribing.

pkej’s picture

subscribe

navid.kashani’s picture

subscribe

OFF’s picture

necessary module for updating

dwynne@gmx.de’s picture

subscribe

Barfly’s picture

subscribe ^^

luckystrikerin’s picture

subscribing

luckystrikerin’s picture

subscribe

threading_signals’s picture

elFinder File Field Source, asks for this module for D7.

l33tdawg’s picture

Any updates?

barobba’s picture

subscribe

mattbk’s picture

Subscribing. Media seems too large for this single purpose.

thoughtcannon’s picture

subscribe. waiting for D7 . . .

7wonders’s picture

+1 more

l33tdawg’s picture

Does anyone have quicksketch's email? Perhaps would be worth dropping him a note - he's not updated his Twitter feed for over 3 weeks even.

quicksketch’s picture

l33tdawg, I'm still regularly checking my issue queue, it's just that this is not a high-priority module for me, even though I know it is for a lot of other people. This module was a proof-of-concept that I put together in a weekend initially, I hadn't anticipated it becoming quite so popular. I've ported 12 of my 16 contributed modules, some of them are just taking a while for me to get around to reviewing and updating. Apologies this is taking so long, but I still don't have a timetable for porting this module. I'll get to it when I can.

joakimekroos’s picture

+1
Really looking forward to this.

l33tdawg’s picture

@quicksketch - Good to know you're still around and thanks for jumping in with an update on what's going on; much appreciated!

I do hope (and I'm sure everyone else who's +1 or sub'ed to this page would agree) that you'd be able to get at least an alpha port for D7 done so possibly others can pick up and continue on... Thanks in advance man and keep up the good work!

Subbo’s picture

subscribe

electblake’s picture

Did anyone take a look at the work done at #52 (http://drupal.org/node/864800#comment-4106268)?

I know this module is a requirement for me (or something to fill this gap) so I'll be looking at a D7 port, but any insight and help from others will be a great aid. Post your work in the que and hopefully our code will form a release in no time!

attiks’s picture

andros’s picture

Subscribing

electblake’s picture

@attiks thanks for the update! great news!

toxiclung’s picture

subscribe

bdunwood’s picture

@quicksketch I see an offer for a EUR 300 contribution to this effort. Would some additional $ help motivate you or another capable developer? If so, what might that number be? Seems like there are a lot of interested people here. Maybe you could set up a contributions page for this effort?

quicksketch’s picture

@bdunwood, I'm not positive that the 300 EUR is still a valid offer since it was based on a client deadline. Honestly, what would be my "selling point"? I'd say $800, which would bring this inline with about how much time it's going to take me to finish this based on my normal community rate. I don't buy much into pledges. If you're serious you can use the donation form at http://quicksketch.org. Any contribution at all has a weird physiological effect, so don't be concerned with "fulfilling" such a pledge. I think my average donation rate I receive is about $20/mo to put it in perspective, haha.

Tebb’s picture

@quicksketch: Small donation made to buy you a beer. No strings attached. Thanks for all your work.

mortendk’s picture

nopes dude they are stilll on the table - we need this & it will save me a lot of hours explaining to a client we he cant use the images he upload to the imce as images for a field ;)

TripX’s picture

+1

carlos.macao’s picture

subscribe

quicksketch’s picture

Just an update here. I've begun work on the D7 version based off bfroehle's patch in #52 (thanks for that!) I've got all the settings saving and FileField Sources affecting individual file/image fields. Unfortunately in addition to all the CCK-to-FieldAPI changes just about every source needs to be rewritten in some way, since the changes to the FileAPI are pretty significant too. It's coming along, just a bit slowly. Thanks for patience.

bfroehle’s picture

quicksketch: Thanks for the update. I'm happy to do debugging / testing / real work if you push the work in progress to a development branch. :)

mortendk’s picture

could someone please chipind the rest of the $ so we can fuel quicksketch motor ;)
300€ is about 435$ ... i mean youre not expecting me to pay the whole thing or is everyone just waiting it out ?

if theres 100+ people that are subscribingto this and sees it as a dealbreaker to their work, is there any reason to hold back seriously ?

attiks’s picture

consider it done, I'll add another 250€

l33tdawg’s picture

I'm up for EUR80-100

mortendk’s picture

awesome :) Quicksketch ive paypalled you the gold *cracking the whip*

mavimo’s picture

Issue tags: +image, +views, +search, +field
FileSize
230.39 KB
57.4 KB

I'm working on widget for image field to use views to search already available files and load new file, you can see screenshot into attachment. I think can realase first alpha into next week ;)

Shadlington’s picture

@mavimo Hmmm... That seems like possible duplication of what the media module can already do.

Tebb’s picture

Am I missing something? Why is #103 relevant to this D7 upgrade thread?

Shadlington’s picture

Issue tags: -image, -views, -search, -field

Its not really :)

attiks’s picture

Nathan i just paypalled 250 euro

Shadlington’s picture

Well that's $796.18... So I guess that's the target met then :)

basicmagic.net’s picture

subscribe

quicksketch’s picture

Hi guys, thanks for the funding! I'll get at least the Attach, Remote, and Autocomplete sources working this weekend and IMCE working by the end of next weekend (April 24th), and we'll target an official release by that date. There are also several other users lurking out there that made contributions (aimeee and howard.taylor). Thanks to everybody even if you're not claiming credit. :)

mortendk’s picture

wooho thats great news :)

bdunwood’s picture

@quicksketch I (actually CMSWire.com) just donated another $200. Thanks for keeping us posted.

l33tdawg’s picture

Donation made - Really looking forward to this :)

TripX’s picture

offtopic - how is it possible to donate? Didn't find something on the desc page of the module.

@quicksketch: Great news!

Tebb’s picture

@TripX

You can donate for QuickSketch's work on this project at: http://quicksketch.org

kueblert’s picture

+ suscribed

jerdavis’s picture

Excited to see this come to 7! Thanks quicksketch and everyone who contributed!

quicksketch’s picture

Hi all, thanks again for the continued contributions! Here's the progress that I've made so far. I ran into a few snags but the good news is FileField Sources looks to be completely feasible in Drupal 7. Most of the changes that I built into the D7 File module were theoretical, so it's good to see that the features that made FileField Sources possible are still maintained.

I've committed these two patches to the project, for D7 compatibility and D6 backports for maintenance. In addition to the field settings being configurable and affecting the node form, the Remote URL source is now completely working. The "Attach" reference is mostly functioning but doesn't save files correctly. The "Reference Existing" works but can't auto-complete file names yet due to silliness in the FieldAPI (which is no longer entirely SQL based, so doing a simple JOIN is more complicated that it should be). I know we'd targeted Sunday (today/yesterday depending on where you are) as having 3 sources working, but we're not quite there yet. We've got great progress though and I figured everyone would be happy to know that we're definitely moving forward. All this code has been committed to Git and we'll continue with additional patches from here.

toxiclung’s picture

i just installed from git and applied the patch, yes!
@quicksketch : you're a lifesaver

luckystrikerin’s picture

Couldn't patch attach.inc, imce.inc, referenc.inc, remote.inc
Now get the following message: Notice: Undefined index: filefield_sources in filefield_sources_form() (line 88 of /var/www/drupal/sites/all/modules/filefield_sources/filefield_sources.module).

RobLoach’s picture

Priority: Normal » Major
Issue tags: +awesomesauce

Yeah, I'm getting the same hunk failures at attach.inc, imce.inc, reference.inc and remote.inc....

Applying a patch to the project via git is probably the best way to go through this, but it's still much more difficult then just rolling off of a straight git repo. Nate, mind just committing what you have to the project's 7.x-1.x branch? Once this is in, I'd be happy to run through it... 54KB patches kill kittens. Think of the kittens :-) .

... And yes, this is major awesomesauce.

quicksketch’s picture

Priority: Major » Normal

Nate, mind just committing what you have to the project's 7.x-1.x branch?

Heh, yeah sorry I meant to actually push the changes but I had just committed them locally without pushing. Hard habit to break. The patches above are committed into the corresponding 6.x-1.x and 7.x-1.x branches now.

bfroehle’s picture

And, you can grab a snapshot of the 7.x-1.x code directly from the git repository at http://drupalcode.org/project/filefield_sources.git/snapshot/7.x-1.x.tar.gz :)

luckystrikerin’s picture

still not works for me. Get this message: Notice: Undefined index: filefield_sources in filefield_sources_field_process() (line 132 of /var/www/drupal/sites/all/modules/filefield_sources/filefield_sources.module).

toxiclung’s picture

i can patch my copy just fine, but Remote URL doesnt seem to work.
after transfer reach 100% the upload form is reset and nothing is displayed.

mortendk’s picture

and kaboom with the imce:

Fatal error: Call to undefined function content_fields() in /Users/mortendk/Dropbox/websites/drupal7/sites/drupal7.local/modules/contrib/filefield_sources/sources/imce.inc on line 77

quicksketch’s picture

Yeah I haven't started IMCE. That's next weekend (per #110).

mavimo’s picture

@Shadlington @Dru-p: it is similar to a source for filefield_sources, it enable to reuse already loaded files and using views to search (using exposed filter) the file to add. I'm starto to remove my work and add it as a source for filefield_source module.

Tebb’s picture

Thanks for clarification MaViMo :)

Which version are you adding your 'existing files source' to?

It's probably best to start a *new issue* to track the progress of your *new feature* and maybe add a link to it here.

mavimo’s picture

@Dru-p I start to rewrite my feature on fielfield_sources branch 7.x-1.x , before reading this post my feature was a simple widget to apply on single file/image field, now I'm try to rewrite it to integrate with fielfield_source.

manveru’s picture

Could you please export strings of version 7.x for the translation to the localize.drupal.org?

jeffwidman’s picture

subscribe

Screenack’s picture

+1

akagroundhog’s picture

FileSize
731 bytes

One tiny bug in attach.inc: it should be $settings['path'] instead of $settings['filefield_source_attach_path'] in line 130; patch to latest (at the moment) Git's snapshot (c46319c1b603f4e76242374b1d1901ed36c8c03b) is attached.

But that's a minor problem. Clicking on "Attach" button leads to Ajax error with messages:

Notice: Undefined variable: form_state in filefield_source_attach_value() (line 201 of /.../sites/all/modules/filefield_sources/sources/attach.inc).
Recoverable fatal error: Argument 1 passed to drupal_array_get_nested_value() must be an array, null given, called in /.../modules/field/field.form.inc on line 451 and defined in drupal_array_get_nested_value() (line 6253 of /.../includes/common.inc).

I've tried to find the problem out by myself, but unfortunately I haven't so much time.

RowboTony’s picture

Hi, I'm using this on a Drupal 7 Commerce site because - many of my items share the same image, however the regular "default image" for this field is not appropriate for my purposes.... so I downloaded the .git project untar and enabled it.... this is exactly what I needed! The 7x .git version works GREAT! I love it, I love you, let's get this bad-boy uploaded to the official downloads page yes? Awesome work, THANK YOU!

-Tony

quicksketch’s picture

Status: Needs work » Fixed
FileSize
17.72 KB
2.33 KB

@tgroff: I literally committed a fully-usable version to the D7 branch less than an hour ago, make sure you're running the latest. :)

@all: I've finished the D7 port! I'm certain there are (significant) bugs in the implementation, but we have a very solid start. All sources are working under the most common conditions (public files, SQL-storage engine for fields, basic image and file fields), including IMCE.

I've committed this new round of patches to the project (plus a README.txt) and I'll be making a beta release on the project page shortly (once I run through the other low-hanging fruit in the issue queue). Thanks everyone for their contributions in all forms.

For my sanity sake DO NOT REOPEN THIS ISSUE. File new issues for any bugs introduced by these patches or for any other features or D7 bugs. The port is complete, now it's just bugs.

manveru’s picture

Component: Code » General

Awesome! You're great! I am waiting published beta.

knaffles’s picture

Thanks for the port!!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

fender-dupe’s picture

is it possible to to multiple images upload with this module somehow, maybe with imce?

Scott J’s picture

TryMupload module.

fender-dupe’s picture

it is not ready for d7

Scott J’s picture

Fender, sorry if it doesn't work for you; Mupload is OK for me, or I would not have suggested it. According to the module page "This module is for Drupal 7 only!"

You do need to use the version of Plupload posted at http://drupal.org/node/1140666 though.

fender-dupe’s picture

but whre are the files for mupload?

I can see it is in sandbox, so i can delete plupupload?