Descriptive text for anonymous users in checkout page cannot be translated - Patch [#736966]

If anonymous checkout is enabled, the descriptive text
<b>Optional.</b> New customers may supply custom account details.<br />We will create these for you if no values are entered.
cannot be translated since the text is retrieved from the variables table.

The attached patch corrects this.

Comment	File	Size	Author
	ubercart_checkout.patch	1016 bytes	reglogge

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

TR CreditAttribution: TR commented 9 March 2010 at 17:26

Status:

Needs review

» Closed (works as designed)

i18n already has a mechanism for translating variable table variables - that's what you should use. That's why this line appears in uc_cart.module:

  $conf['i18n_variables'][] = 'uc_cart_new_account_details';

Besides, your patch is just wrong - you're throwing away the variable but leaving the admin menu that allows you to configure that variable?

Comment #2

laghalt CreditAttribution: laghalt commented 17 November 2010 at 08:58

Besides that reglogge´s patch works.

Yes - there is a i18 variable that dosent work. The original bugg might be that that variable is flushed somewhere in the code or somthing like that.

If you cant find that error since you dont have dev-documentation - this is a correkt buggreport.

Thanks for the fix.

Comment #3

mducharme CreditAttribution: mducharme commented 19 March 2012 at 18:24

Status:

Closed (works as designed)

» Needs review

Why was this patch not pushed into a release? $conf['i18n_variables'][] = 'uc_cart_new_account_details'; does not work and other #description fields within ubercart do not use the variable_get at all and use the patch's format:
/modules/ubercart/uc_cart/uc_cart_checkout_pane.inc: $description = t('Enter a valid email address for this order...);

Comment #4

19 March 2012 at 18:26

Status:

Needs review

» Needs work

The last submitted patch, ubercart_checkout.patch, failed testing.

Comment #5

TR CreditAttribution: TR commented 20 March 2012 at 04:34

Status:

Needs work

» Closed (works as designed)

We don't need more than one issue open for this. You can contribute to #1257488: Make shipping quote pane description and error message really translatable if you want. But be aware that this is something that probably needs to be fixed in the i18n module, since it's i18n that doesn't properly work for variables defined outside a system_settings_form().