Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The new standard in Drupal core is to avoid using field set if there is only one present or when it is the main interaction. Here the same applies because, there are vertical tabs but the actual Identification fieldset holds no value.
Comment | File | Size | Author |
---|---|---|---|
#13 | drupal.comment-node-type.patch | 710 bytes | sun |
#10 | content-types-fieldset-locale-664012-10.patch | 838 bytes | cburschka |
#6 | content-types-fieldset.patch | 1.32 KB | Dries |
#1 | fieldsetnodetypesremoval_before.png | 15.17 KB | Bojhan |
#1 | fieldsetnodetypesremoval_after.png | 14.38 KB | Bojhan |
Comments
Comment #1
Bojhan CreditAttribution: Bojhan commentedAfter
Comment #2
yoroy CreditAttribution: yoroy commentedbot?
Comment #3
Dries CreditAttribution: Dries commentedIf we remove the fieldset, we can simplify the rest of the form API structure too. We move things up from the second level, to the first level in the array.
Comment #4
Bojhan CreditAttribution: Bojhan commentedSo removing ['identity'] from those which where in the fieldset, oke.
Comment #5
Dries CreditAttribution: Dries commentedCorrect.
Comment #6
Dries CreditAttribution: Dries commentedHere is an updated patch. Ran the Node tests locally with (
$ /Applications/acquia-drupal/php/bin/php scripts/run-tests.sh --url http://cvs.localhost:8082/ --php /Applications/acquia-drupal/php/bin/php Node
) and they still pass.Comment #7
Bojhan CreditAttribution: Bojhan commentedAhh, cool :) Faster then me, I just tested it and it works. RTBC
Comment #8
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.
Comment #9
cburschkalocale.module, in locale_form_node_type_form_alter() depends on the [identity][type] key and should have been updated to [type].
This caused #666402: Translation workflow options are broken which in turn is causing part of #666266: HEAD is broken - various test failures.
Comment #10
cburschkaThis is wonderful - the one-line patch actually fixes *all* of translation.module's test failures. :)
Comment #11
catchTest bot, we have missed you.
Comment #12
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks, Arancaytar.
Comment #13
sunAlso broke Comment module's form alter.
1) We should check all other hook_form*_alter() implementations.
2) We badly need the testbot back.
Comment #14
Dries CreditAttribution: Dries commentedCommitted #13 to CVS HEAD. We still need tests, so leaving at 'needs work'.
Comment #16
yoroy CreditAttribution: yoroy commentedIs 'needs tests' still a critical?
Comment #17
Bojhan CreditAttribution: Bojhan commentedDoesn't seem critical.
Comment #18
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedI suppose this still needs tests.
Comment #19
catchComment #20
xjm(Merging "node system" and "node.module" components for 8.x; disregard.)