Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In response to:
http://www.youtube.com/watch?v=7uSsnls16q0
Added target="_blank" to all links in install.php.
Comment | File | Size | Author |
---|---|---|---|
new_windows_for_install_help.diff | 12.6 KB | JacobSingh | |
Comments
Comment #1
Dries CreditAttribution: Dries commentedThe target-attribute will break XHTML 1.0 Strict validation. I don't think that is a critical problem, but there are Javascript alternatives that do validate. Any thoughts? I think this patch is a step in the right direction.
Comment #2
yoroy CreditAttribution: yoroy commentedtagging
Comment #3
Bojhan CreditAttribution: Bojhan commentedI think we need a universal solution to this.
Comment #5
Bojhan CreditAttribution: Bojhan commentedBojhan: XHTML (which i hate) became modularized and target is a module that needs to be loaded (in the doctype in the HTML header) so that's quite possible to fix
chx: oke great,
Bojhan: http://dionidium.com/tests/extend-xhtml/xhtml-strict
Bojhan: [ ] needs to be added to doctype.
chx: and thats only required on the pages which need this functionality?
Bojhan: right but it does not hurt on others
So lets do this, and apply it where it is REALLY needed. So we can for once fix this damm thing.
Comment #6
dcor CreditAttribution: dcor commentedI'm not sure if this is related or that we need a new issue for it ---
When following a link off the admin pages.. (i.e. in appearance where it says "alternative themes are available") where "themes" is a link to the main drupal site...
If I click on the link (or shift click to open in a new window) - it takes me to the themes page on drupal - my problem is I can't get this to open in another tab/window (using firefox here).
I think these links (in general - that are all over the place) should automatically open a new tab or window... as otherwise, you're moving away from your site and you have to go back and start all over again to find where you left off.
Hope this makes sense - I'm installing and running D7 properly so as to make up some themes and figure I may as well report on what I find!
Cheers.
Comment #7
TR CreditAttribution: TR commentedComment #16
quietone CreditAttribution: quietone as a volunteer commentedA policy issue has been opened to discuss this problem, #2702881: [policy, no patch] Formalize how external links are handled in core. And since that has not been resolved, changing this to postponed.