bzip2 misnomer [#394234]

I just tried this module for the first time, and I'd say that it's a very welcome addition to my grown collection of Drupal admin modules. Well done.

I do have one nitpick, however. The backup settings offers "BZip" as a compression option and the resulting file is suffixed ".sql.bz".

The file that I got out of it was, however, compressed with bzip2. The original bzip had software patent issues, has been discontinued for 8 years or so, and is quite hard to come across.

So I'd suggest that this option be renamed "bzip2" (no caps) and the file extension changed to ".sql.bz2" to avoid problems with unarchivers that might get confused about which algorithm to use :)

Comments

Comment #1

ronan CreditAttribution: ronan commented 7 March 2009 at 17:15

Thanks for the info. I was unaware of the history of bzip. I never actually use it myself and only stuck it in there because it was supported in php and didn't seem like too much more effort. I haven't caught the issue, because I use Mac OS X and the built in archiver seems to handle the .bz files just fine.

Changing the ui is trivial, but I'll have to be careful changing the file extension since that's how the module detects what you're passing to it on restore. I don't want to break compatibility with people's existing backups.

I'll see what I can do about getting this change into the 1.x branch, but may just make the change going forward in the 2.x branch for the sake of consistency.

Thanks
Ronan