Move search from user module to Search

Fix Drupal\Tests\search\Functional\GenericTest::testModuleGenericIssues. The error is related to routes but I am not sure what the proper fix is. Anyone?

Symfony\Component\Routing\Exception\RouteNotFoundException: Route "search.view" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 214 of core/lib/Drupal/Core/Routing/RouteProvider.php).

Drupal\Core\Routing\UrlGenerator->getRoute() (Line: 281)

Adding more detail for the error.

PHPUnit

1) Drupal\Tests\search\Functional\GenericTest::testModuleGenericIssues
Behat\Mink\Exception\ExpectationException: Current response status code is 500, but 200 expected.

/var/www/html/vendor/behat/mink/src/WebAssert.php:888
/var/www/html/vendor/behat/mink/src/WebAssert.php:145
/var/www/html/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:79
/var/www/html/core/modules/system/tests/src/Functional/Module/GenericModuleTestBase.php:50

browser output

The website encountered an unexpected error. Try again later.

Symfony\Component\Routing\Exception\RouteNotFoundException: Route "search.view" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 214 of core/lib/Drupal/Core/Routing/RouteProvider.php).

Drupal\Core\Routing\UrlGenerator->getRoute() (Line: 281)
Drupal\Core\Routing\UrlGenerator->generateFromRoute() (Line: 105)
Drupal\Core\Render\MetadataBubblingUrlGenerator->generateFromRoute() (Line: 776)
Drupal\Core\Url->toString() (Line: 33)
Drupal\search\Hook\SearchHooks->help() (Line: 301)
Drupal\Core\Extension\ModuleHandler->invoke() (Line: 119)
Drupal\help\Controller\HelpController->helpPage()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->{closure:Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber::wrapControllerExecutionInRenderContext():121}() (Line: 619)
Drupal\Core\Render\Renderer::{closure:Drupal\Core\Render\Renderer::executeInRenderContext():619}()
Fiber->start() (Line: 620)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->{closure:Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber::onController():96}() (Line: 183)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 36)
Drupal\Core\Test\StackMiddleware\TestWaitTerminateMiddleware->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 30)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 199)
Drupal\page_cache\StackMiddleware\PageCache->fetch() (Line: 136)
Drupal\page_cache\StackMiddleware\PageCache->lookup() (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 61)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 54)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 753)
Drupal\Core\DrupalKernel->handle() (Line: 19)

The route search.view is used in search.links.menu.yml. It is setup in \Drupal\search\Routing\SearchPageRoutes::routes() but only if there there is a defined default search page. For some reason there is no default search page.

I did a bit of a tidy on the recent changes. I removed the getting the route provider only because I found it easier to read without separating out a part of a paragraph.

Adding a try/catch in hook help for the case when the route search.view doesn't exists works for this case. But what of the uses of the route in contrib?

Would it be better to go to a page with a message like 'no search pages available'?