Problem/Motivation

Search module is being deprecated so move all the search related code from the Node module to the Search module.

    core/modules/node/config/install/core.entity_view_mode.node.search_index.yml
    core/modules/node/config/install/core.entity_view_mode.node.search_result.yml
    core/modules/node/config/optional/search.page.node_search.yml
    core/modules/node/config/schema/node.schema.yml

Steps to reproduce

Proposed resolution

Create a sub module search_node for the moved code.

Remaining tasks

Deprecate the search plugin
Other changes as needed
Move tests for node searching to the new module

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3587564

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !15628

quietone’s picture

quietone commented

Moved user_search plugin and config from the user module to a sub module in Search, search_user. That is working and a manual test of updating worked as well.

Did the same for node module, moving that to search_node. A manual test of update fails, with The "node_search" plugin does not exist. There is also more search related code in the node module that should move.

quietone’s picture

quietone commented

There was a cspell error that was not detected by commit-code-check locally, It was in core/modules/search/modules/search_node/config/schema/search_node.schema.yml.

quietone’s picture

quietone commented
Title: Move search config to Search module » Move search functionality from node to Search module
Status: Active » Needs review
quietone’s picture

quietone commented
Issue summary: View changes

Setting to needs review to see how this is going. Reviews should pay attention to all the configuration changes. I am not sure they are correct.

There are tests in the Search module that can probably be moved to search_node, I just haven't looked at that yet.