Problem/Motivation

Track the steps needed to deprecate extension Search. See Remove a core extension and move it to a contributed project of the deprecation policy.

The removal of extension Search was approved in #3476883: [Policy, no patch] Move Search module to contrib.

Remaining tasks

  1. Begin finding someone to maintain the contrib version of the extension.
  2. Add the extension to the list of the Upcoming Deprecations.
  3. Move integrations implemented by other modules to the extension.
    Create child issues or child meta issues, as needed, to address the following points. Not all points will apply to all extensions.
  4. Remove references to the extension from database dumps.
  5. Remove templates from the extension’s markup.
    • Remove templates from themes that are staying in core, leave them in deprecated themes
    • Keep skipping the template in the stable copies test.
  6. Do a thorough search of core for any remaining references to the extension. If references are found, outside of the extension, then create issues to remove the references.
  7. Create the contrib project with a stable release, before the alpha version of the major release. Follow the process in Create the contrib project with a stable release for creating the sub tree split.
  8. Deprecate the core extension. #3565781: Deprecate the Search module
  9. Open an issue, 'Ensure that Search module does not get special core treatment' in the packages.drupal.org issue queue to ensure that the composer namespace for the contributed project matches the core one after removal. This is to allocate the drupal/search Composer namespace to contrib extension rather than the core extension.
  10. Update the Deprecated and obsolete extensions

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented

These tests install Search

  • core/modules/block/tests/src/Functional/BlockHiddenRegionTest.php
  • core/modules/help/tests/src/Functional/HelpTopicSearchTest.php
  • core/modules/help/tests/src/Kernel/HelpSearchPluginTest.php
  • core/modules/jsonapi/tests/src/Functional/SearchPageTest.php
  • core/modules/layout_builder/tests/src/FunctionalJavascript/LayoutBuilderDisableInteractionsTest.php
  • core/modules/node/tests/src/Functional/NodeAccessBaseTableTest.php
  • core/modules/node/tests/src/Functional/NodeTranslationUITest.php
  • core/modules/page_cache/tests/src/Functional/PageCacheTagsIntegrationTest.php
  • core/modules/settings_tray/tests/src/FunctionalJavascript/SettingsTrayBlockFormTest.php
  • core/modules/system/tests/modules/form_test/src/Form/FormTestLabelForm.php
  • core/modules/system/tests/src/Kernel/Entity/ConfigEntityImportTest.php
  • core/modules/toolbar/tests/src/Functional/ToolbarAdminMenuTest.php
  • core/modules/user/tests/src/Functional/UserSearchTest.php
  • core/modules/views/tests/src/Functional/DefaultViewsTest.php
  • core/modules/views/tests/src/Functional/SearchIntegrationTest.php
  • core/modules/views/tests/src/Functional/SearchMultilingualTest.php
  • core/modules/views/tests/src/Kernel/Entity/ViewEntityDependenciesTest.php
  • core/tests/Drupal/FunctionalJavascriptTests/Ajax/AjaxFormCacheTest.php
  • core/tests/Drupal/FunctionalTests/Theme/OliveroTest.php
  • core/tests/Drupal/FunctionalTests/Theme/OliveroTest.php
  • core/tests/Drupal/KernelTests/Core/Recipe/RecipeTest.php
quietone’s picture

quietone commented
Issue summary: View changes

Talked to catch about about skipping handling the migration tests due to the fact the Migrate Drupal and family is being removed and not ported to contrib and that the migrations in Search are all configuration migrations. We both agreed that it OK in this case. I have updated the issue summary accordingly.

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Issue summary: View changes
smustgrave’s picture

smustgrave commented

Just noting that there is some config in the node module for search.

quietone’s picture

quietone commented
Issue summary: View changes

Yes, search is in lots of places. Support for search is in: claro, default_admin, demo_umami, starterkit, and olivero. Also theme.api.php and entity.api.php. And comment module.

quietone’s picture

quietone commented

#3575605: Move tests of search to search module committed

quietone’s picture

quietone commented

I think these are the config that need to be handled.

  • core/modules/node/config/install/core.entity_view_mode.node.search_index.yml
  • core/modules/node/config/install/core.entity_view_mode.node.search_result.yml
  • core/modules/node/config/optional/search.page.node_search.yml
  • core/modules/node/config/schema/node.schema.yml
  • core/modules/user/config/optional/search.page.user_search.yml
  • core/modules/user/config/schema/user.schema.yml
kentr’s picture

kentr commented

Olivero has some libraries related to Search.

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Issue tags: +11.5.0 release priority

Search core for usages of the Search module is difficult because 'search' is also used in database code and view for example.

For themes alone there are 321 uses of the word search.

$ git grep search | grep core/themes | wc -l
321