Problem/Motivation

The Search module is used in olivero_test

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3586616

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !15552

quietone’s picture

quietone commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

quietone commented
Status: Fixed » Needs review
dcam’s picture

dcam commented
Status: Needs review » Needs work

I can't verify that the tests are actually running. Please check the test output. I expected to see two instances of a test named oliveroRemoveBlockConsoleTest.js run, but there's only one. It appears to be the original one in core/tests/Drupal/Nightwatch. I also expected to see oliveroSearchFormTest.js in the output, but it's missing.

I don't know anything about Nightwatch testing, but it looks like there may be an expectation that the JS files should be in a Tests subdirectory, e.g. core/modules/search/tests/src/Nightwatch/Tests/. The three other core modules with Nightwatch tests (ckeditor, navigation, and toolbar) follow this convention. Maybe they need to be moved.

Otherwise the code splits and moves look OK to me. I didn't really find anything to comment about.

quietone’s picture

quietone commented
Status: Needs work » Needs review

@dcam, thanks for finding that.

The test, oliveroRemoveBlockConsoleTest,js is now running twice, once for each file.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback appears to be addressed on this one

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed f3e6745 and pushed to main. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • alexpott committed 8f0bafa4 on main 
    task: #3586616 Remove search from olivero_test module

By: quietone
By:...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: main » 11.x-dev

Backported to 11.x do allow search to be deprecated there.

Committed cb1f6e0 and pushed to 11.x. Thanks!

  • alexpott committed cb1f6e05 on 11.x 
    task: #3586616 Remove search from olivero_test module

By: quietone
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.