Deprecated function: preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in email_registration_strip_mail_and_cleanup() (line 160 of modules/contrib/email_registration/email_registration.module).
Check if the account if anonymous, and if so, don't change the name in the email_registration_username sub-module.
Review patch and apply.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | email_registraion-3505848-02.patch | 1004 bytes | dubs |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
dubs commentedPatch to fix
Comment #3
ptmkenny commentedThanks for reporting this. Could you please create an MR instead of a patch so that the CI tests can be run?
Comment #6
grevil commentedThanks for finding this! Although, the current change would introduce a breaking change, as we would never enter the switch case. Currently, only the "default" case is problematic the other two are fine.
Although, I am starting to wonder where these settings are even coming from and if we really need them? There isn't even a settings page to set any of these. The code is from me, but I don't remember what this is for. I'll need to have a deeper look in a separate issue.
For now, we can temporarily move the early anonymous return inside the default case to avoid any breaking changes, in cases where someone set the "username_display_override_mode" manually via config. NW until adjusted.
Comment #7
grevil commentedComment #8
grevil commentedThis should do the trick and prevent BC.
Comment #9
lrwebks commentedLGTM as a temporary solution, simple and effective.
Comment #10
grevil commented