Problem/Motivation

Enable "Contrib modules" and "Core modules" plugins.

Visit the "Extend > Browse" page. You can see the "Contrib modules", but there is no way to access to the "Core modules".

Tried:
- /admin/modules
- /admin/index

The URL /admin/modules/browse/drupal_core shows the page that we want, but that URL is not exposed or linked anywhere on the project.

Proposed resolution

Create tab or link somewhere.

Issue fork project_browser-3501455

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fjgarlin created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Category: Bug report » Feature request

I am reproducing this on 2.0.x.

The problem is that the sources have to opt in to showing a local task by putting it in their annotation. For example, the drupalorg_jsonapi source does it: https://git.drupalcode.org/project/project_browser/-/blob/2.0.x/src/Plug...

But the drupal_core source doesn't: https://git.drupalcode.org/project/project_browser/-/blob/2.0.x/src/Plug...

So we have a couple of options here.

  • We could add that to the drupal_core source, except that it would create a conflict with the existing /admin/modules (Extend) tab, since they both show core modules.
  • We could do nothing, and close this as "works as designed".
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Title: Unable to access the "Core modules" source » Expose the "Core modules" source plugin as a local task
Issue tags: +Usability
fjgarlin’s picture

fjgarlin commented

/admin/modules shows both core and contrib modules in the system, so whilst PB is not a full replacement for that page (we're not there yet), I think we should add the tab for "Core modules" if we are willing to offer that via PB.

Maybe the name of the tab for "Contrib modules" should be "Contrib modules" instead of "Browse", and the "Core modules" should be "Core modules". Or maybe not, I'm not sure, this is UX, but yeah, my point remains that the plugin is available and when enabled, you can't see it anywhere (this is why I created it as a bug).

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented

I agree that if we're going to be enabling a local task for core modules, the contrib source should not be named "Browse". It was only kept that way for parity with 2.0.x to minimize disruption while I was making the seismic change of ripping out the Svelte-managed tabbing. But now that the tabs are regular local tasks, "Browse" is nonsensical.

davit.magaldadze made their first commit to this issue’s fork.

gprtskh made their first commit to this issue’s fork.

gprtskh opened merge request !684

gprtskh’s picture

gprtskh commented
Status: Active » Needs review

Only local images are allowed.

chrisfromredfin made their first commit to this issue’s fork.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Looks fine to me! The failing tests are probably random failures, but I don't have permission to rerun those jobs.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented

re-ran tests and they passed. will merge this soon, after the larger categories one.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the help! Great to see some new names in the queue :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.