EnabledSourceHandler is still messy, because it suffers from the old design that presumed that Project Browser had internal tabbing and could store all data, for all tabs, in one place.

Let's improve that:

  • It should no longer be possible to send a query to the backend proxy without a source ID.
  • Queries and results for each source should be cached by EnabledSourceHandler in a key-value storage specific to that source.
  • It should be possible to clear storage for a single source.

Issue fork project_browser-3498560

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phenaproxima created an issue. See original summary.

phenaproxima opened merge request !668

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » Unassigned
Status: Active » Needs review
fjgarlin’s picture

fjgarlin commented
Status: Needs review » Needs work

The code looks good and it reflects what we need. However, I don't see the tabs anymore (not sure this is introduced by these changes). I enabled core and contrib modules.

https://8080-project-drupalpod....gitpod.io/admin/modules/browse/drupalorg_jsonapi shows contrib modules
https://8080-project-drupalpod....gitpod.io/admin/modules/browse/drupal_core shows core modules

But there are no tabs shown in the front end, at all. No JS errors, no watchdog errors.

Using the developer tools we can see that the project-browser/data/categories returns data for the two enabled plugins.
The project-browser/data/project only returns data for the plugin that is present in the URL.

I'm going to test with 2.0.x and see if this happens ===> This also happens in 2.0.x, without this MR applied. That means there is no regression in here.

fjgarlin’s picture

fjgarlin commented
Status: Needs work » Reviewed & tested by the community

chrisfromredfin made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Reviewed & tested by the community » Fixed

yeah boi, onward and upward

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.