Problem/Motivation
Sub-module webform_bootstrap was deprecated in the parent issue. The deprecation links to What to do about deprecated external libraries in Webform 6.x+, but this page does not mention Bootstrap.
Proposed resolution
Add documentation explaining the deprecation. Add status page warning when webform_bootstrap from webform is installed.
Remaining tasks
Add status page warning.
User interface changes
None.
API changes
None.
Data model changes
None.
Issue fork webform-3492971
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
jrockowitz commentedWe could also move this code to the webform_deprecated project.
Comment #3
jrockowitz commentedI am realizing that Bootstrap 3.x is still supported. We can keep the code deprecated in the core webform module but tweak the webform_bootstrap.module to only work with Bootstrap 3.x.
Comment #4
jrockowitz commentedI think can we assume no one is creating new sites with Bootstrap 3.x, and we should remove the Bootstrap check in hook_requirements. This will allow us to move the webform_bootstrap.module to https://www.drupal.org/project/webform_deprecated.
Comment #5
liam morlandMakes sense.
Comment #8
jrockowitz commentedComment #10
joseph.olstadI'm creating new bootstrap 3 sites including one I just created this week. What are the implications of these changes to the webform module? Should I be forking something today?
Bootstrap 3.34 was released December 3rd 2024, in only 17 days being available there's already nearly 6000 installs.
Comment #11
joseph.olstadBootstrap 3.34 is compatible with Drupal 11 today and there's no plans to stop at 11.
Drupal 11 is currently planned to be getting security maintenance until June 2028
Comment #12
liam morlandI think support for things like Bootstrap should be in separate projects. There is already webform_bootstrap5.
Comment #13
joseph.olstadok so basically fork webform_bootstrap into a seperate contrib project, this works for you?
Comment #14
liam morlandI would be fine with that. @jrockowitz?
Comment #15
jrockowitz commentedI am okay with someone creating and maintaining a dedicated webform_bootstrap project.
Comment #16
amir jamshidi commentedHello every one.
I installed the https://www.drupal.org/project/bootstrap/releases/8.x-3.35 template but now I have this error
I finally had to disable and delete the webform_bootstrap module.
Comment #17
yesct commentedThis doesn't seem like a release blocker to me. (Just noting.) Priority normal seems fine to me also.
Comment #18
jrockowitz commentedI think we need to fork the webform bootstrap 3 module into a dedicated project and deprecate the code in the webform module.
Comment #19
yospyn commentedHi - I work on a Drupal 10.4.5 site that's been using Bootstrap 3 for a long time and here's what I observed:
- Upgraded to 6.3@beta from 6.2.9, webforms appear normal with webform_bootstrap still installed
- Uninstalled webform_bootstrap (since deprecated) and webform styling gets a little wacky
Thus, for the moment, I'm not uninstalling webform_bootstrap on production. So it would be great to have this submodule still available in some way.
Comment #20
joseph.olstad@yospyn, we're using webform_bootstrap with Drupal 11.1.6 and the latest webform module 6.3.0-beta2.
As for deprecating, I think it's too soon to deprecate. Bootstrap 3 will be supported for the duration of jQuery 4 and possibly beyond. There's tens of thousands of installs.
with that said, could fork if needed as mentioned earlier.
Comment #21
liam morlandThe best thing would be to create a separate
webform_bootstrapmodule project.Comment #22
joseph.olstad@liam morland, forking is problematic for a few reasons, mainly the bumpy ride for existing installs and it's not going to be something that automatically happens for those upgrading. People will stumble before they find the solution.
With that said, I'll maybe run a few tests with a faked out local fork before I comment further.
Comment #23
liam morlandI think we should deprecate
webform_bootstrap, removing it in 6.4.x. People can usewebform_bootstrap5or fork it off if needed.We could add a message to the status page when
webform_bootstrapis installed informing people that it is deprecated.Comment #24
joseph.olstad@liam morland, thanks for the reminder. Unfortunately webform_bootstrap is already marked as deprecated!
Deprecating a module that is still required and used by many indefinately causes disruption and discomfort and possibly panick to everyone still using and needing webform_bootstrap.
Would be nice if there was a friendlier way to deal with moving modules around. It's quite an annoyance when a module just vanishes and then an upgrade becomes a quagmire for those experiencing it.
I have forked to webform_bootstrap as a precautionary measure.
https://www.drupal.org/project/webform_bootstrap is the new home. It is marked as supported.
What I would like for the webform project is updated documentation instructing everyone that relies on webform_bootstrap to use the supported version of webform_bootstrap that I am providing.
The deprecation messaging is unfortunate but as a minimum should be updated to note that this module will be supported at the new location as a seperate module.
Comment #25
liam morlandI have updated the documentation to mention the new
webform_bootstrapproject.I think all that is needed now is a status page warning when
webform_bootstrapfromwebformis installed.Comment #26
liam morlandThis message appears when
webform_bootstrapfromwebform is installed:Comment #28
joseph.olstad@liam morland, it would be better if the message said this instead:
"Deprecated modules found: Webform Bootstrap (3.x), replacement at https://www.drupal.org/project/webform_bootstrap"
would be a much friendlier deprecation message.
Would you please be so kind as to suggest how to make this change?
I'm thinking of these n00b sys admins.
Comment #29
liam morlandThe message is provided by Drupal core based on the
lifecyclekeys in the info files. If you click on the link, it provides additional information. I have updated the links to go straight to the right part of the page.Comment #30
joseph.olstadok sounds good, thanks @liam morland.
Comment #32
cilefen commented