Problem/Motivation

Drupal 11 requires classes that extend ConfigFormBase include the $typedConfigManager argument.

Drupal\menu_breadcrumb\Form\SettingsForm already includes the argument, but the order is incorrect.

See https://www.drupal.org/node/3404140

Steps to reproduce

  • Install Drupal 11.
  • Install menu_breadcrumb
  • Notice the error below.

Fatal error: Type of Drupal\menu_breadcrumb\Form\SettingsForm::$typedConfigManager must be Drupal\Core\Config\TypedConfigManagerInterface (as in class Drupal\Core\Form\ConfigFormBase) in /var/www/html/docroot/modules/contrib/menu_breadcrumb/src/Form/SettingsForm.php on line 0

Proposed resolution

Change the order of the arguments in the SettingsForm constructor and create() method.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 3485520-8.patch5.56 KBsmulvih2
#4 Screenshot from 2024-11-06 10-28-12.png74.71 KBatul_ghate

Issue fork menu_breadcrumb-3485520

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

byrond created an issue. See original summary.

byrond opened merge request !26

atul_ghate made their first commit to this issue’s fork.

atul_ghate’s picture

atul_ghate commented
StatusFileSize
new Screenshot from 2024-11-06 10-28-12.png74.71 KB

I have fixed all the PHPCS issues, but the pipeline is still showing PHPCS warnings.(see attached screesnhot)

atul_ghate’s picture

atul_ghate commented
Status: Active » Needs review
hatuhay’s picture

hatuhay commented
Priority: Normal » Critical

Set as critical, it breaks the site upon installing breaking the database if enabled with other modules leaving installation half the way.

marcoliver’s picture

marcoliver
he/him
Primary language German
Location Neuss, NRW, Germany
commented
Status: Needs review » Reviewed & tested by the community

Can confirm, that the issue fork unbreaks the current 2.0.x state of the module.

Marking RTBC.

smulvih2’s picture

smulvih2
Location Canada 🍁
commented
StatusFileSize
new 3485520-8.patch5.56 KB

Adding patch from MR to use in my project.

+1 this works for me, was getting critical error when running Drush during an upgrade.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Reviewed & tested by the community » Fixed

Thanks all, merged.

xurizaemon credited mably.

xurizaemon credited pfrenssen.

xurizaemon credited srjosh.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented

xurizaemon credited anwar_max.

xurizaemon credited bramdriesen.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.