Problem/Motivation
As per @phenaproxima
Not a blocker, but we will definitely want to change this wording in a follow-up. Would you be willing to open one for that?
In #3330887: GUI install multiple modules at once., multiple projects can be installed at once and a button is added to Queue/Dequeue the projects.
This issue is to decide and then implement the suggested name for Queue/Dequeue button text.
Steps to reproduce
Proposed resolution
Use "Add to Queue" and "Remove from Queue" (this may be too long, but let's do it and see!)
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | claro_bulkoperationsbar.jpg | 97.28 KB | leslieg |
Issue fork project_browser-3476807
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
narendrarComment #3
bsnodgrass commentedQueue and Dequeue, while short don't describe the action. "Add to queue" or "Remove from queue" would be preferable and easier to understand. (or maybe "+ Queue" and "- Queue")
Comment #4
leslieg commentedWouldn't using the term "install" also make it clearer? "Add to install queue" or "Remove from install queue" .
Comment #5
leslieg commentedAdding comment from @lostcarpark from Sitebuilder Subcommittee call on 10/15:
"Another approach might be to have a sidebar with the install queue always visible in the sidebar. When there's nothing queued, it could contain a message like "Items queued for install will be shown here. Use 'Add' and 'Remove' buttons to select modules to install, and press 'Install' when ready."
Comment #6
leslieg commentedAdding comment from @rkoller from Sitebuilder Subcommittee call on 10/15:
"ui wise i would orient to the ui pattern used on admin/content for bulk operations. at the moment the add and install button for project browser is just a free hovering button at the button at the bottom of the page."
Comment #10
leslieg commentedAdding comment from @chrisfromredfin in slack:
"Yeah I am preferring it as a banner all the way across the bottom, the way gin does bulk operations"
Comment #11
leslieg commentedAdditional comments from today's Project Browser slack meeting:
rkoller: ah no then it is like in claro i was refering to. just styled slightly different.
the claro one is just easier to recognize in black
rkoller: in comparison gin has a black box for the bul operations. that has a clear color contrast against the white background while gins light blue makes it disappear against the white background has a color contrast of 1.1:1 in gin compared to 15.5:1 in claro.
but the pattern is identical just different styling.
in gin it just breaks with SC1.4.11 that way. but that is the point utilizing already existing ui patterns. and that bulk operations bar went through a lot of discussions
see attached file - claro_bulkoperationsbar.jpg
Comment #12
lavanyatalwar commentedHey @leslieg,
Personally, I prefer using "Add to queue" and "Remove from queue" for clarity—it just feels more intuitive. I also really like the UI approach that Gin uses for bulk operations; I think it strikes a good balance between functionality and visibility.
Comment #13
chrisfromredfinComment #14
chrisfromredfin(Also, I've created a child issue to change the layout of the bulk operations bar for the install queue - so we can keep this issue scoped to copy)
Comment #17
utkarsh_33 commentedI have added the text's for the buttons in 2 different cases as per the proposed resolution.Marking it NR.
Comment #18
tonypaulbarkerI found this confusing (my install multiple button had gone because of a front end bug and was hidden so I had to do some reading to figure out what should happen).
This is my opinion:
I would like to see a simple install button per project and a checkbox to select and deselect to install multiple recipes if I want to. I think that select and deselect is the correct wording for that. As an end user I don't think I will have an opinion on the order in which things are installed so the language of queuing things doesn't make sense to me.
If we are going to keep the button format and don't want to use a checkbox then I agree with #4. The reason I was confused is because I intend to 'install' these rather than 'queue' them.
Comment #19
rkoller@chrisfromredfin made a good point in a discussion on slack:
I agree that queue/batch are both challenging and abstract terms, but for me batch is less abstract as a none native english speaker (it would be easier to explain to someone else), plus i always prefer to use precise denomination. so why not instead of going with
Add to queuego withAdd to batchinstead?In regard of #18 - there is a child issue to this one (#3484474: Change UI for the install queue to match bulk operations} that is about adding a bulk action bar at the bottom of the page like you have on
/admin/content. that bar will always be in the visible viewport (if it behaves like the one on the content page) and within the action select list the default action is shown. there you could basically use the button labels that were used before the queue button was introduced and that way it would be clear what will actually happen ( my suggested actions on the issue are "add and install" and "add"). there might be only the person who is using project browser for the first time or someone who only wants to install a single module (like the case you've described in #18 @tonypaulbarker), for those there might be "friction" with the current plan until the first module is added. definitely a valid concern.Comment #20
rkollerTwo or three weeks ago I've done an impromptu user test, asking attendees of the Drupal Dojo Austin about their first impression about certain parts of Project Browsers browser page. For the reference, that nights attendees were @rocketeerbkw and @cutehair. On the browse page both considered the word "queue" challenging, there was also the uncertainty in one initial reaction what queue actually means and implies. But they've also considered the pattern of using a regular button for adding a module to the queue not that helpful.
After explaining the functionality behind, as well as pointing to the planned bulk action component outlined in #3484474: Change UI for the install queue to match bulk operations, their feeling was a checkbox would be the more suitable and familiar interface pattern for adding something to the batch. The currently used "toggle" button functionality is not that apparent and it was also noted that both button states only differ by their button labels, there are no other visual queues, so the user has to actually read to distinguish which modules have been added to the batch yet. The cognitive load is sort of high that way.
The suggestion was to add a "stylized" checkbox to the button, so modules not added and installed would have "add to batch" as the button label (picking up the suggestion from #19) with an unticked checkbox, while a pressed button would have the same button label "add to batch" but a ticked checkbox. That way sighted users dont have to distinguish between uniform looking buttons that differ just based on their button label . Same for screenreader users where the aural interface does not really announces the actual button state, there is always the uncertainty for someone without the visual context "am i in the unqueued state and by pressing the button i will move the module into the queued state or is it the other way around?". ( a similar problem is illustrated by leonie watson with the example of the light and dark theme toggle button over here https://youtu.be/OUDV1gqs9GA?t=3220)
if you make the button a switch button with a fixed label of for example "add to batch" in for example voiceover a screenreader user gets the announcement "add to batch" for the not pressed button and "add to batch selected" for the pressed button. that way the state is crystal clear there as well. and for both the rest of the necessary details could be communicated on the bulk action component.
Comment #21
chrisfromredfinComment #22
pameeela commentedI also think 'Select' and 'Deselect' (or 'Unselect' ??) are probably the least confusing. I think we should avoid use of the word 'queue' altogether. It might not be totally expected what happens when you click 'Select' but at least it's pretty clear in the meaning. And once you select something, you get the 'Install' button so the next step is still clear enough.
There are of course other things we can do to improve the UX of this, but I think updating this wording should be a priority since it is the UX that we have now.
Comment #23
narendrarChanges are aligned with #22, marking as RTBC.
Comment #24
rkollerhaving dedicated labels (select and deselect) for the different states is sort of problematic for screenreader users, see #20 (the linked video illustrates the problem)
Comment #25
chrisfromredfinshipping this as-is as the incremental improvement that it is to what we have; however, i've pulled Ralf's (very valid) comment over to the child issue, so all of it can be fixed there. Checkbox approached is seconded in #18, too.
Comment #27
chrisfromredfinship it