Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#15 3435379 display.png527.75 KBcsakiistvan
#15 3435379 edit.png201.6 KBcsakiistvan
#7 view_mode_selector.1.x-dev.rector.patch404 bytesproject update bot
#6 Screenshot 2025-01-03 at 3.59.20 PM.png22.72 KBabhi_khandelwal
#2 view_mode_selector.8.x-1.1.rector.patch404 bytesproject update bot

Issue fork view_mode_selector-3435379

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new view_mode_selector.8.x-1.1.rector.patch404 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-127659

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.9
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !1

peelas02 made their first commit to this issue’s fork.

peelas02 opened merge request !2

abhi_khandelwal’s picture

abhi_khandelwal commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2025-01-03 at 3.59.20 PM.png22.72 KB

The #MR2 works for both Drupal 10 and Drupal 11. Attaching the upgrade status screenshot for reference. Moving the issue to RTBC.

project update bot’s picture

project update bot commented
Version: 8.x-1.1 » 8.x-1.x-dev
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new view_mode_selector.1.x-dev.rector.patch404 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-392907

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.6
  2. mglaman/phpstan-drupal: 1.3.2
  3. palantirnet/drupal-rector: 0.20.3
weseze’s picture

weseze commented
Issue summary: View changes

abhi_khandelwal report that the patch from #2 works. There is no difference in the other patches/MR's.
When can we expect a Drupal11 compatible release?

pfrenssen changed the visibility of the branch project-update-bot-only to hidden.

pfrenssen changed the visibility of the branch 3435379-automated-drupal-11 to hidden.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented

It would be nice if this was merged. Drupal 11 has been released for a while now.

chris dart’s picture

chris dart commented

I see no reason for this not to be merged.

chris dart’s picture

chris dart commented

I am happy to help out with the merge and release. You could temporarily add me as a contributor to the project if you want.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: Unassigned » csakiistvan
csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3435379 edit.png201.6 KB
new 3435379 display.png527.75 KB

Environment

  • Drupal: 11.4.1
  • PHP: 8.5.5
  • Database: MariaDB 10.11.16
  • DDEV: v1.25.2
  • view_mode_selector: 8.x-1.x-dev (MR !2, branch 3435379-d11_ready)
  • Browser: Chrome

Prerequisites

  • A Drupal 11 site.
  • For the functional check: paragraphs enabled, a "Page reference" paragraph type holding an entity reference to a page node plus a View Mode Selector field, and an Article whose paragraph reference field renders the paragraph with the View mode selector view mode.

Root cause

The module declared core_version_requirement: ^9 || ^10, which excludes Drupal 11. Installing it on Drupal 11 fails with "module 'view_mode_selector' is incompatible with this version of Drupal core." The module's PHP APIs are already Drupal 11 compatible, so only the version constraint needs updating.

Steps

  1. Apply the fix from MR !2: update core_version_requirement to ^10 || ^11 in the module's info file.
  2. Rebuild caches: ddev drush cr
  3. Install the module on Drupal 11 and confirm it enables without the incompatibility error.
  4. Add a View Mode Selector field, choose a view mode with its widget, and view the entity to confirm it renders in the selected view mode.

Expected results

  • The module installs on Drupal 11 with no core-compatibility error.
  • The View Mode Selector field, its widgets and formatter work: the selected view mode is applied when the entity is rendered with the module's placeholder view mode.

Actual results

Before the fix, enabling the module on Drupal 11.4.1 failed with "module 'view_mode_selector' is incompatible with this version of Drupal core." After changing core_version_requirement to ^10 || ^11, the module installs cleanly. A functional check confirmed the behaviour end to end: a "Page reference" paragraph with a View Mode Selector field was rendered through an Article; selecting "Card" rendered the referenced page as a teaser (body shown), and switching the selector to "Link only" rendered it as a plain title link (no body) — confirming the placeholder view mode is correctly rewritten to the selected view mode on Drupal 11.

Testing produced with the assistance of an LLM.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: csakiistvan » Unassigned
rkelbel48’s picture

rkelbel48 commented

Everything is testing fine with the proposed update, are the maintainers just no longer available?

yannickoo’s picture

yannickoo
Location Berlin
commented
Assigned: Unassigned » yannickoo

Hey @rkelbel48! I will have a look into this during the next days 💪

yuraul made their first commit to this issue’s fork.

yannickoo’s picture

yannickoo
Location Berlin
commented
Assigned: yannickoo » Unassigned
Status: Reviewed & tested by the community » Fixed

This has been fixed and View Mode Selector can be used for Drupal 11 without Lenient Composer patch 🎉

Thanks to everyone!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented

Good job guys, thanks <3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.