Drupal 11 compatibility [#3429692]

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

If the issue is reopened, then new automated changes will be posted.

If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

Review the merge request and test it.
Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comment	File	Size	Author
#8	currency-automated-drupal-11-compatibility-fixes-3429692-8.patch	60.5 KB	v.dovhaliuk
#5	currency.3.x-dev.upgrade_status.post_rector.txt	9.07 KB	project update bot
#5	currency.3.x-dev.rector.patch	53.75 KB	project update bot
#5	interdiff-last-bot.6922582.txt	6.33 KB	project update bot
#4	currency.3.x-dev.upgrade_status.post_rector.txt	6.93 KB	project update bot
#4	currency.3.x-dev.rector.patch	49.17 KB	project update bot
#4	interdiff-last-bot.6911607.txt	0 bytes	project update bot
#2	currency.8.x-3.4.rector.patch	49.17 KB	project update bot

Issue fork currency-3429692

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

project-update-bot-only changes, plain diff MR !4
Check out this branch for the first time

Check out existing branch, if you already have it locally
3429692-automated-drupal-11 compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

17 March 2024 at 09:26

Project Update Bot created an issue. See original summary.

Comment #2

project update bot commented 17 March 2024 at 09:26

Status:

Active

» Needs review

Status	File	Size
new	currency.8.x-3.4.rector.patch	49.17 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #11-121090

This patch was created using these packages:

drupal/upgrade_status: 4.1.0
mglaman/phpstan-drupal: 1.2.7
palantirnet/drupal-rector: 0.20.1

Comment #3

17 March 2024 at 09:27

Project Update Bot opened merge request !4

Comment #4

project update bot commented 4 April 2024 at 14:56

Version:

8.x-3.4

» 8.x-3.x-dev

Status	File	Size
new	interdiff-last-bot.6911607.txt	0 bytes
new	currency.3.x-dev.rector.patch	49.17 KB
new	currency.3.x-dev.upgrade_status.post_rector.txt	6.93 KB

This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-137198

These packages were used to generate the fixes:

drupal/upgrade_status: 4.1.0
mglaman/phpstan-drupal: 1.2.10
palantirnet/drupal-rector: 0.20.1

Comment #5

project update bot commented 17 June 2024 at 23:35

Status	File	Size
new	interdiff-last-bot.6922582.txt	6.33 KB
new	currency.3.x-dev.rector.patch	53.75 KB
new	currency.3.x-dev.upgrade_status.post_rector.txt	9.07 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Debug information

Bot run #11-199781

These packages were used to generate the fixes:

drupal/upgrade_status: 4.3.2
mglaman/phpstan-drupal: 1.2.11
palantirnet/drupal-rector: 0.20.3

Comment #6

17 June 2024 at 23:40

Status:

Needs review

» Needs work

The last submitted patch, 5: currency.3.x-dev.rector.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #7

7 November 2024 at 15:19

somersoft made their first commit to this issue’s fork.

Comment #8

v.dovhaliuk commented 27 December 2024 at 10:09

Issue summary:

View changes

Status	File	Size
new	currency-automated-drupal-11-compatibility-fixes-3429692-8.patch	60.5 KB

A new patch has been provided since using MR as a patch is a security issue.

Comment #9

afagioli

Rome

commented 26 May 2025 at 19:41

following

Comment #10

27 May 2025 at 01:03

jeremy1606 made their first commit to this issue’s fork.

Comment #11

dahousecat commented 13 June 2025 at 09:39

Patch #8 works well for me

Comment #12

pfrenssen

Sofia

commented 30 July 2025 at 12:52

Let's not mark any tests as skipped. It is better to let them fail so we have good visibility on the work that is still needed. Marking tests as skipped gives a false sense of progress.

Comment #13

pfrenssen

Sofia

commented 30 July 2025 at 13:18

We have a lot of deprecation warnings coming from one of our dependencies (commercie/currency). There is an upstream PR to fix these: https://github.com/Commercie/currency/issues/8

Comment #14

pfrenssen

Sofia

commented 30 July 2025 at 14:22

Status:

Needs work

» Postponed

I'm impressed with the tremendous work that was done here, thanks @jeremy1606 and others! I updated the tests and locally they are all passing if I apply the patch from https://github.com/Commercie/currency/issues/8

I guess this is now postponed on https://github.com/Commercie/currency/issues/8 but the library seems to have been written by @Xano to support this module, and does not seem to be maintained any more.

Comment #15

pfrenssen

Sofia

commented 30 July 2025 at 16:08

Status:

Postponed

» Needs review

A big shout out to @Xano for suddenly coming out of the woodwork and adding me as a maintainer to the upstream commercie/currency library! I have merged the fix and issued a new release. Now our tests are all green, and this is ready for review again!

Comment #16

pfrenssen

Sofia

commented 2 October 2025 at 19:11

Status:

Needs review

» Needs work

I did a review of the MR. There is still some work left.

Comment #17

pfrenssen

Sofia

commented 2 October 2025 at 19:12

8 files were hidden/shown/deleted

Status	File	Size
hidden	currency.8.x-3.4.rector.patch	49.17 KB
hidden	interdiff-last-bot.6911607.txt	0 bytes
hidden	currency.3.x-dev.rector.patch	49.17 KB
hidden	currency.3.x-dev.upgrade_status.post_rector.txt	6.93 KB
hidden	interdiff-last-bot.6922582.txt	6.33 KB
hidden	currency.3.x-dev.rector.patch	53.75 KB
hidden	currency.3.x-dev.upgrade_status.post_rector.txt	9.07 KB
hidden	currency-automated-drupal-11-compatibility-fixes-3429692-8.patch	60.5 KB

Comment #18

pfrenssen

Sofia

commented 8 October 2025 at 21:02

Status:

Needs work

» Needs review

It is totally OK to use AI agents to help with repetitive tasks like adding missing documentation, but please review every single line of AI generated code carefully before committing it. The LLMs can make a right mess of things. I just spent my entire evening fixing hundreds of lines by hand.

Anyway apart from this, the sheer amount of work that was done is incredible, thanks a lot @jeremy1606 for the effort!

This still needs another review before it can be committed.

Comment #19

pfrenssen

Sofia

commented 9 October 2025 at 06:19

Status:

Needs review

» Reviewed & tested by the community

Did a final review, looking good! Thanks all!

Comment #20

9 October 2025 at 06:24

pfrenssen committed 5728fd9b on 8.x-3.x authored by project update bot

[#3429692] feat: Drupal 11 compatibility

By: jeremy1606
By: somersoft...

Comment #21

pfrenssen

Sofia

commented 9 October 2025 at 06:27

Status:

Reviewed & tested by the community

» Fixed

Comment #22

9 October 2025 at 06:27

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Comment #23

pfrenssen

Sofia

commented 9 October 2025 at 06:27

Title:

Automated Drupal 11 compatibility fixes for currency

» Drupal 11 compatibility

Comment #24

23 October 2025 at 06:29

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #25

jerech commented 31 October 2025 at 22:13

Hello, I participated in the “Drupal 11 compatibility” task for the “Currency” module, and no one gave me any attributes or credits for my participation. You are a maintainer, and I wanted to ask if you could give me attributes or credits for my company and for myself? Thank you very much in advance.

Comment #26

berdir

German

Switzerland

commented 31 October 2025 at 22:29

I saved the credits, @pfrenssen clearly looked at the contribution UI and used the generated commit message, but it's very easy to miss that you have to actually save them and have to be logged in to do so.

Comment #27

jerech commented 3 November 2025 at 06:25

Thanks for the clarification! I wasn’t aware that saving the credits manually and being logged in were required steps that explains a lot. I really appreciate you taking the time to explain it.

I’ll make sure to follow the correct process next time. Thanks again for your work and support!

Comment #28

pfrenssen

Sofia

commented 3 November 2025 at 12:15

Sorry about this, I am still getting used to this new procedure, I indeed added you as a contributor but forgot to press save. I will try to do better next time!