Hello all, it’s time for the fortnightly coding standards meeting.

This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Is held on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Usually happens fortnightly. Alternating between Tuesday 2100 UTC and Wednesday 0900 UTC.
➤ The meeting open for 24 hours to allow for all time zones.
➤ Discussion is done in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously.
➤ Has a public agenda anyone by adding a comment to the meeting issue.
➤ A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
➤ The transcript will include comments made during the 24 hours of the meeting. However, comments made after the 24 hours may not be in transcript.

Current ping list: @catch, @larowan, @longwave, @quietone
@dww, @borisson_ @longwave @Björn Brala, @Aaron McHale, @Alex Skrypnyk, @Urvashi, @Kingdutch

Comments

larowlan created an issue. See original summary.

larowlan credited Arkener.

larowlan credited bbrala.

larowlan credited borisson_.

larowlan credited dww.

larowlan credited kim.pepper.

larowlan credited longwave.

larowlan credited mherchel.

larowlan credited urvashi_vora.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all time zones.

Björn Brala (bbrala) Good morning 🙂
larowlan :sunrise:
Alex Skrypnyk Hi all :))
dww :wave:
kimb0 :wave:
longwave :wave:
Arkener :wave:
urvashi_vora :wave:

1️⃣  Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

dww Might be too late, but would love a thread on #3405089: Refine CS process based on the experience of #3303206 so we agree how we want to manage tags during the process…

2️⃣ Action items

2️⃣.1️⃣ Approve previous minutes

larowlan It looks like we haven't collated the minutes yet (see #3402696: Coding Standards Meeting Tuesday 2023-11-21 2100 UTC) @urvashi_vora is that something you could do as you ran the meeting? See https://github.com/mdlutz24/drupal-meeting-parser for instructions
urvashi_vora Sure, I can do this
urvashi_vora I will update the ticket by tomorrow morning 10:30 AM IST (edited)
urvashi_vora I have updated the issue summary, can someone please review the conversation for the meeting..#3402696: Coding Standards Meeting Tuesday 2023-11-21 2100 UTC

2️⃣ .2️⃣ #3405089: Refine CS process based on the experience of #3303206 (edited) 

larowlan via @dww
dww Would be great to agree on how we tag things at each stage in the process. Eg how we tag for core committer approval, do we tag for other things, do we leave it in RTBC the whole rest of the process, etc.
larowlan I think we should propose some tags, and document them in the process
larowlan Not fussy about the tags, just the fact they're documented and in the process
urvashi_vora I agree
urvashi_vora We definitely need some tag for that

2️⃣ .3️⃣ TBD

3️⃣ RTBC issues to review

3️⃣ .1️⃣ #3303206: Define a standard for adding declare(strict_types=1) this has gone out in the blog post and next step is committer feedback. There is a meeting today (edited) 

dww Glad y’all have a meeting today. Thanks for bringing this (and the other) for approval.
Arkener Happy to see this one move forward, thanks for the hard work on this. 💙
urvashi_vora Hoping to see this get fixed soon

3️⃣.2️⃣#3295249: Allow multi-line function declarations this also was in the blog post. The remaining tasks need updating here as this is also up to core committer discussion I think. I'll add to today's meeting too

3️⃣ .3️⃣ #3074131: Use null coalescing operator ?? instead of a ternary operator with an isset() condition this one looks to have consensus. If we can agree in this meeting, it can go into the next blog post (And be tagged as such)

dww I’m in favor.
dww If there are no objections, let’s put it out on the next blog.
larowlan I'm in favour too
Björn Brala (bbrala) Well, I've supported the issue. So yeah
borisson_ I agree, no objections here
Björn Brala (bbrala) ok, i'll add it to the doc.
urvashi_vora +1, thanks @Björn Brala (bbrala)

4️⃣ Fixed since last meeting - none -

5️⃣ #3324368: Update CSS coding standards to include PostCSS and Drupal 10 @mherchel has updated the google doc and wondering what next steps are here

Björn Brala (bbrala) Seems a chnage record us still missing. But perhaps that shouldn't block it being discussed at core meeting if a read earlier comments. Seems rtbc is fine to be set.Could this be discussed coming core meeting?
Björn Brala (bbrala) Change record added.
Björn Brala (bbrala) And i rtbc'd, since that felt like the right thing to do. If possible this should get a place in core meeting hopefully.
Björn Brala (bbrala) cc @larowlan @catch @quietone
larowlan Oh sorry yeah I got it into the core committers meeting
larowlan We might need a different process here because of the size of the change and how outdated the current rules are
larowlan We're proposing just making this change in one go
mherchel let me know if there's anything I can do to help out :smile:

6️⃣ Draft blog post #3406351: [2023-12-12] Draft blog post

7️⃣ Wrap up. Well that was a :tumbleweed: meeting but hopefully folks catch up in the threads

Alex Skrypnyk @larowlani though we had 24 hrs for review before the meeting is closed:))do we still have that time?
larowlan yeah we do, but the admin-lead bit is normally 1hr. We don't expect the person to hang around for 24 hrs
larowlan but in terms of minutes, 24hrs at least
Alex Skrypnyk thank you
urvashi_vora Thank you for hosting the meeting @larowlan
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
urvashi_vora’s picture

urvashi_vora commented
Status: Needs review » Reviewed & tested by the community

LGTM

urvashi_vora’s picture

urvashi_vora commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.