Coding Standards Meeting Tuesday 2023-11-21 2100 UTC [#3402696]

Hello all, it’s time for the fortnightly coding standards meeting.

This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Is held on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Usually happens fortnightly. Alternating between Tuesday 2100 UTC and Wednesday 0900 UTC.
➤ The meeting open for 24 hours to allow for all time zones.
➤ Discussion is done in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously.
➤ Has a public agenda anyone by adding a comment to the meeting issue.
➤ A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
➤ The transcript will include comments made during the 24 hours of the meeting. However, comments made after the 24 hours may not be in transcript.

Current ping list: @catch, @larowan, @longwave, @quietone
@dww, @borisson_ @longwave @Björn Brala, @Aaron McHale, @Alex Skrypnyk, @Urvashi, @Kingdutch

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all time zones.

mstrelan	Michael, Australia
larowlan	:wave:
mahaveer003	:wave:
catch	Nat, UK
Kingdutch	:wave:
Björn Brala (bbrala)	:upside_down_face:
dww	Derek :wave:
Aaron McHale	Oh the meeting is 9am my time, I thought it was 9pm for some weird reason :smile: (edited)
Aaron McHale	I wasn't clear if the meeting is in the core calendar? Can anyone confirm (I don't use Google Calendar so can't easily check)
longwave	:wave:
quietone	Hi, catching up.

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.

mstrelan	#3303206: Define a standard for adding declare(strict_types=1)
urvashi_vora	Posted a thread 3️⃣.1️⃣ (edited)
Kingdutch	Might be a bit arbitrary (possibly out of scope for this meeting) but for projects that are using Behat, I'm working on a Cucumber linter that can be run in a similar manner to PHPStan: https://github.com/Kingdutch/cucumber-linter-src/Current open work before a 0.1.0 release is to configure PHAR packaging.

2️⃣ Action items

2️⃣.1️⃣ Approve previous minutes

urvashi_vora	#3397055: Coding Standards Meeting Wednesday 2023-11-07 2100 UTC
larowlan	We need to sort the credits, but other than that looks good

2️⃣.2️⃣ TBD (edited)

mstrelan

Sorry this is the same as 3.1

2️⃣.3️⃣ TBD

3️⃣ RTBC issues to review

3️⃣.1️⃣ #3303206: Define a standard for adding declare(strict_types=1)

larowlan	I think there's broad consensus amongst members here, so next step is to get +1 from committers
mstrelan	The IS talks about two different things, the position and the spaces. I'm confused if there is consensus on the spaces.
larowlan	I think there's consensus around no spaces, matching PSR 12
larowlan	Do folks agree?
catch	No spaces is what everyone is doing, so I think we should use that. I think the idea about adding spaces was to make things easier for coder in other places where we require spaces, but that doesn't seem like a reason to diverge from what humans are naturally doing.
larowlan	And there's already a coder rule for both flavours
dww	So, committee is agreed? Next step is the blog post and the waiting?
quietone	I've updated the IS and commented with a link to the issue for the blog post.

3️⃣.2️⃣ #3392321: Relax the "Conditions should not be wrapped into multiple lines" rule for more code readability

larowlan	+1 from me
Björn Brala (bbrala)	Yeah same, read through it and agree
dww	There’s some disagreement in the issue on if there should be an initial condition in the first line with the if or not.
dww	We need to be clear what we’re agreeing with. :sweat_smile:
Björn Brala (bbrala)	Hmm
Björn Brala (bbrala)	I'll revisit later
Aaron McHale	Added a comment

3️⃣.3️⃣ #3295249: Allow multi-line function declarations

larowlan	+1 from me
Björn Brala (bbrala)	Same for me. Thinking if I need to comment then.
dww	I’ve been +1 on this one for a long time. :sweat_smile:
Aaron McHale	+1 from me!
quietone	This one is also tagged for change record updates.I think that should be done before the announcement.
quietone	Does anyone have time to look into that?
Björn Brala (bbrala)	Tomorrow I might have

3️⃣.4️⃣ #3324368: Update CSS coding standards to include PostCSS and Drupal 10

larowlan	There's a lot of action items/open threads on the Google doc still
quietone	I am not convinced that the background section should be in the standards either. I think the standards should simply state what is done now.