Problem/Motivation

First let me say that the module editor templates is awesome, It was what we wanted for a long time to incorporate it into our page builder.

But If you try to save as template a layout that is inside another layout if fails. The modal opens but the field template content is empty.

If i try to save the first level layout, with the children within it works well.

Issue fork mercury_editor-3398498

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Carlitus created an issue. See original summary.

johntarling made their first commit to this issue’s fork.

johntarling opened merge request !19

johntarling’s picture

johntarling commented

We ran into this issue too. I've created an issue fork with the fixup. It also sorts out some of the permission references where incorrect casing was used.

johntarling’s picture

johntarling commented
Status: Active » Needs review
carlitus’s picture

carlitus commented

Tested and now it works well, thanks @johntarling!

justin2pin made their first commit to this issue’s fork.

justin2pin’s picture

justin2pin commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Thanks for all the work on this! Should be all set, just needs tests added.

carlitus’s picture

carlitus commented

I tested again and it works

carlitus’s picture

carlitus commented

Tested with 2.1 dev and it seems that all works well

justin2pin’s picture

justin2pin commented
Status: Needs work » Needs review
justin2pin’s picture

justin2pin commented
Status: Needs review » Fixed

This is merged - thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

justin2pin’s picture

justin2pin commented
Status: Closed (fixed) » Needs work

Reopening this issue. The following produces an error:

  1. Fresh install.
  2. Create a page. Add single column section (eg with full width) and create content to stamp out to template (I used image, then text).
  3. Stamp out to a template. Save page (draft is fine) and exit editing.
  4. Create a second page. Add double column, and insert template into first column.
  5. Save and Exit.
  6. Re enter page from (4). Delete the double column section. Do not save/exit.
  7. Re-add a double column, insert template into first column.
  8. Save page - inserted template now lands up beneath the double column section (here with full width as per step (2).

justin2pin opened merge request !27

justin2pin changed the visibility of the branch 3398498-saving-layout-inside to hidden.

justin2pin changed the visibility of the branch 3398498-saving-layout-inside to active.

  • justin2pin committed e20d3732 on 2.1.x 
    Issue #3398498: Saving layout inside layout as template fails
justin2pin’s picture

justin2pin commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.