Problem/Motivation

Using Gin admin theme after this commit https://git.drupalcode.org/project/field_group/-/commit/1211c8f4e0659241... the required marks are displayed on every tab item, even those that are already marked as required previously.

Steps to reproduce

Upgrade to dev-3.x 1211c8f and using Gin as admin theme.

CommentFileSizeAuthor
#25 3395375-25-4.x.patch1.38 KBrpearl
#24 3395375-field_group-duplicate-require-3.x-24.patch2.1 KBjedihe
#6 3395375-6.patch546 bytesandrerb
fieldgroupduplicated.png10.38 KBalbefer

Issue fork field_group-3395375

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

albefer created an issue. See original summary.

albefer’s picture

albefer commented
Issue summary: View changes
albefer’s picture

albefer commented

It seems the issue is in this file https://git.drupalcode.org/project/field_group/-/blob/1211c8f4e06592418c.... With this commit, we have switched from using .text() to .html() to build the content of the tabs. As a result, HTML tags, such as <span class="required-mark"></span>, are now included in the tab titles.

3cwebdev’s picture

3cwebdev commented

We are seeing this issue as well when using Horizontal Tabbed field groups on the Gin theme. Switch to vertical tabs or a different theme removes the issue.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Version: 8.x-3.4 » 8.x-3.5

I can confirm that using Gin with Field Group results in gin's tabs.css file being loaded in the front end (due to the Gin admin menu, I assume) and messing up many (all?) of Field Group's horizontal tab styles. 🙁

-mike

andrerb’s picture

andrerb commented
StatusFileSize
new 3395375-6.patch546 bytes
kufliievskyi’s picture

kufliievskyi commented

Thanks for the patch. I confirm that patch #6 fixes the issue. Tested on Drupal 10.3.0.

refs’s picture

refs
Primary language German
commented

I can also confirm that the patch fixes the issue for 3.6 and Drupal 10.3.0.

kevinvb’s picture

kevinvb commented
Status: Active » Reviewed & tested by the community

I can confirm the patch works on 10.3.1 with Gin admin theme 8.x-3.0-rc13 and field group on 8.x-3.6

andreic’s picture

andreic commented

I can also confirm that the patch fixes the issue for 3.6 with Drupal 10.2.6.

butterwise’s picture

butterwise commented

Confirming patch in #6 fixed this issue (8.x-3.6, Drupal 10.2.7, Gin 8.x-3.0-rc13)

jonathan_hunt’s picture

jonathan_hunt commented

Patch #6 worked for me on Field Group 8.x-3.6, Drupal 10.3.3, Gin 3.0.0-rc13.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-3.5 » 4.x-dev

anybody opened merge request !75

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Please use MRs!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Merging based on the many RTBC's.

  • anybody committed 62ed4cc3 on 4.x 
    Issue #3395375: Duplicated required marks in field tabs with GIn admin...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed
grevil’s picture

grevil commented

This introduced a regression. Created a follow-up issue here: #3473033: Horizontal Tabs render broken, if child allows HTML.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pfrenssen’s picture

pfrenssen
Location Sofia
commented

Would it be a good idea to commit this on the stable 3.x branch as well?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@pfrenssen I'm not against it. Still I think we should better focus on a stable 4.0.0 release!

rajab natshah’s picture

rajab natshah
he/him
commented

Thanks, Andre, for the patch in #6!
It is working with the Field Group ~3.0 version.

Hoping this fix makes it into the 8.x-3.x branch, especially since Field Group 4.0.0-alpha1 has been released. Many sites are unlikely to upgrade from ~3 to ~4 until an RC or the stable 4.0.0 release is available.

jedihe’s picture

jedihe commented
StatusFileSize
new 3395375-field_group-duplicate-require-3.x-24.patch2.1 KB

For those of us on 3.6, I'm attaching a patch ported from #3473033: Horizontal Tabs render broken, if child allows HTML #15, only the changes for formatters/tabs/horizontal-tabs.js.

Minimally tested on horizontal tabs, enabling "Mark group as required if it contains required fields." now works as expected: only one required mark, only shown on tab titles for panes actually containing required fields.

rpearl’s picture

rpearl commented
StatusFileSize
new 3395375-25-4.x.patch1.38 KB

I also came across this issue with Gin 4.0.4 and Field Group 4.0.0-alpha1. The "Mark group as required if it contains required fields." checkbox option did not make any difference. I created this patch which gets around the issue and forces the required mark regardless of this option. There should be a better way to do this, but at least this patch would allow me to ensure that the horizontal tabs were always marked correctly (aka, I always want to mark the group required if there are required fields).

jedihe’s picture

jedihe commented

Update: #24 is no longer needed after updating to field_group 4.0.0, using Gin theme.