Problem/Motivation

Blocks have their own configuration. The block-related settings in visitors.config are legacy from D7.

Steps to reproduce

Proposed resolution

Remaining tasks

  • The schema file, visitors.schema, needs to be updated, remove block settings
  • Remove block settings removed from visitors.config
  • Update VisitorsBlock to no longer user legacy settings

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 3376397-6.patch5.78 KBroshni27
#2 3376397-2.patch4.68 KBroshni27

Issue fork visitors-3376397

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bluegeek9 created an issue. See original summary.

roshni27’s picture

roshni27 commented
Status: Active » Needs review
StatusFileSize
new 3376397-2.patch4.68 KB

Removed default block config in visitor config .please review.

jay jangid’s picture

jay jangid commented
Assigned: Unassigned » jay jangid
jay jangid’s picture

jay jangid commented
Assigned: jay jangid » Unassigned

@roshnichordiya, Thanks for providing the patch.
I've tested it with Drupal 9.5.x, and the patch applied successfully.
As a result, the block settings have been removed from the visitors.config file.
Thank you!

bluegeek9’s picture

bluegeek9 commented
Issue summary: View changes
Status: Needs review » Needs work

visitors_update_8212 must not be removed.

roshni27’s picture

roshni27 commented
Status: Needs work » Needs review
StatusFileSize
new 3376397-6.patch5.78 KB

please review the patch.

bluegeek9 opened merge request !122

  • bluegeek9 committed 14d7c397 on 8.x-2.x 
    Issue #3376397 by bluegeek9, roshni27: Remove block settings from...
bluegeek9’s picture

bluegeek9 commented
Status: Needs review » Fixed
bluegeek9’s picture

bluegeek9 commented

This issue was resolved. A new release, 8.x-2.17, will be made soon, May 31st.

This is an excellent opportunity to beta test the dev branch, and report any issues.

Contributors (5)

bluegeek9, roshni27, abhishek_gupta1, sarwan_verma, SandeepSingh199

Changelog

Issues: 32 issues resolved.

Changes since 8.x-2.16:

Bug

Feature

Task

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.