Problem/Motivation

The visitors' reports are reports. It seems they should be under admin/reports instead of config/people.

Steps to reproduce

Proposed resolution

Remaining tasks

  • Update the menu parent
  • Update the paths to be prefixed with /admin/reports/

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 Screenshot from 2023-09-12 14-28-38.png115.66 KBroshni27
#6 visitor-report-path-3376392-6.patch417 bytesroshni27
#4 after_visitors.png115.58 KBroshni27
#4 before_visitors.png101.64 KBroshni27
#2 3376392.patch2.24 KBradhe_shyam

Issue fork visitors-3376392

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bluegeek9 created an issue. See original summary.

radhe_shyam’s picture

radhe_shyam commented
Status: Active » Needs review
StatusFileSize
new 3376392.patch2.24 KB

hello bluegeek9
I solved the issue
I changed parent: system.admin_config_system of Visitors.setting
to + parent: system.admin_reports
and removed
-visitors.index:
- title: 'Visitors'
- route_name: visitors.index
- parent: user.admin_index

Status: Needs review » Needs work

The last submitted patch, 2: 3376392.patch, failed testing. View results

roshni27’s picture

roshni27 commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new before_visitors.png101.64 KB
new after_visitors.png115.58 KB

The above patch applied cleanly, and it is working as expected, as indicated by the screenshot. I recommend moving it to "RTBC +1."

bluegeek9’s picture

bluegeek9 commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work

Hi @radhe_shyam,

Thank you for your contribution to the project.

Removing visitors.index and visitors.routes is not part of the request. Additionally, visitors.settings was updated.

roshni27’s picture

roshni27 commented
Status: Needs work » Needs review
StatusFileSize
new visitor-report-path-3376392-6.patch417 bytes
new Screenshot from 2023-09-12 14-28-38.png115.66 KB

Hi @bluegeek9 Please review the patch, and I have added descriptions as well. If you do not want them, please let me know, and I will update the patch accordingly.

bluegeek9 opened merge request !101

bluegeek9 opened merge request !121

bluegeek9’s picture

bluegeek9 commented
Status: Needs review » Fixed
bluegeek9’s picture

bluegeek9 commented

This issue was resolved. A new release, 8.x-2.17, will be made soon, May 31st.

This is an excellent opportunity to beta test the dev branch, and report any issues.

Contributors (5)

bluegeek9, roshni27, abhishek_gupta1, sarwan_verma, SandeepSingh199

Changelog

Issues: 32 issues resolved.

Changes since 8.x-2.16:

Bug

Feature

Task

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bluegeek9 closed merge request !101

bluegeek9’s picture

bluegeek9 commented