Problem/Motivation

The warning with t() calls comes up when running the phpcs command on the module for the FooterBlock.php file.

Steps to reproduce

Run the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig openchurch_core

Proposed resolution

Use $this->t() instead.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 3358756_warning.png59.02 KBakshaydalvi212

Issue fork openchurch_core-3358756

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sidharth_soman created an issue. See original summary.

sidharth_soman’s picture

sidharth_soman commented

I am working on this and will raise an MR.

sidharth_soman opened merge request !6

sidharth_soman’s picture

sidharth_soman commented
Assigned: sidharth_soman » Unassigned
Status: Needs work » Needs review
akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: Unassigned » akshaydalvi212

I will review the MR.

akshaydalvi212’s picture

akshaydalvi212 commented
Issue summary: View changes
Status: Needs review » Needs work
StatusFileSize
new 3358756_warning.png59.02 KB

hey @sidharth_soman,
thanks for the MR it looks good but,
it still has a warning as shown in the below image.

I will work on it and update the MR.

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: akshaydalvi212 » Unassigned
Status: Needs work » Needs review

MR updated as needed.
kindly review the MR.

drupalninja99’s picture

drupalninja99 commented
Status: Needs review » Fixed

Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.