Starting from Drupal core 10.1.0, block management pages have new paths and menu items. This change directly impacts to Fixed Block Content, which specific UI options relies on the existing one from core.
In a 10.1.0-alpha1 Drupal installation, FBC UI menu entries are not reachable at all.
Update custom UI routes, menu items and paths accordingly to D10.1 changes trying to keep D10.0.x compatibility.
Implementation, review.
According to changes in D10.1+
None.
None.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
mathiasgmeiner commentedThis is an initial, rough patch for Drupal 10.1 and 1.x-dev@dev.
The fixed block content can now be accessed at /admin/content/block/fixed-block-content, although it is still not visible in the user interface.
Comment #3
jacobbell84 commentedI built on this to hit a few more of the bullet points needed to get it committed. My patch adds the Fixed Blocks tab to the block types admin UI area. It also uses route subscribers and derivatives to alter the new routes for older versions of Drupal, maintaining backward compatibility with older versions. I did alter the routes be under the block type area instead of the block content area for Drupal 10.1. Up to manuel.adan of course but my thoughts were since this is technically configuration and not content it made more sense there. Lastly I updated the tests to hopefully work on all versions of Drupal.
Comment #4
jacobbell84 commentedUpdating the patch to fix composer.
Comment #5
jacobbell84 commentedTaking into account new permissions in D10.1
Comment #6
jacobbell84 commentedHopefully addressing the last of the permission issues.
Comment #7
manuel.adanI tested changes both in D10.0 and D10.1. I also tested in an upgraded system from 10.0 to 10.1. Tests passed OK, it seems functional and it's working as expected. Great work!
I just found some CS related issues fixed in the attached update.
Many URL have been changed, so adding redirections from the old to the new ones could be useful. Affected URLs are not public anyway, so might not have many broken links after the upgrade. Shortcuts, aliases or direct link in administration guides would be the only affected. It could be addressed now or in a new issue after this one becomes fixed.
Comment #8
watergate commentedWorks like a charm on both D10.0 and D10.1 :)
Comment #11
falco010Because of the hard requirement of 10.0.0 in this module we could not upgrade to 10.1
I therefor created a fork of the work done here (added patch #7) which can be used till this gets merged to be able to upgrade to Drupal 10.1
To be able to use the fork, add the following to your composer.json repositories:
And run the following command:
Comment #12
jacobbell84 commented@manuel.adan My vote would be a separate issue. This is holding up a few folks doing upgrades so it would be great to get a new release out and then work on refining afterwards if redirects are still needed.
Comment #13
kaszarobertI tested the patch as this blocks D10.1 upgrade right now for us. It's working fine, RTBC+
Comment #14
jv24Latest patch works well - any progress on a new release to support >10.1?
Comment #15
juliakoelsch commentedI can also confirm that the patch is working. I used the fork created by @Falco101 (described in #11) to move forward with upgrading.
Comment #17
manuel.adanCommitted, thank you all! Sorry for the delay, pretty busy at work these weeks.
Comment #19
tgoeg commentedIs there anything open that prevents releasing this as 8.x-1.3?
Would be nice to have a stable version covering everything needed for Drupal 10.1
Comment #20
ion.macaria commentedAgree with @tgoeg. Can we have it release cause other security tools give it like security issue beeng dowloaded from dev branch.
Comment #21
solideogloria commented@manueladan +1 for a new release, please! People need to be able to install the module on Drupal 10.1