Problem/Motivation

If a module is successfully added and or installed the user faces a modal at the end of the process.


problem is you have to click to close the modal. unfortunately the modal doesnt just close if you click outside the modal but you have to click the dedicated close button. and in general the modal doesn't provide any extra information. and the information that the process successfully ran through is already communicated by the changing button state. to acknowledge the successful add and or install by a click already feels cumbersome.

Steps to reproduce

Proposed resolution

Remove the modal since sighted users already have the indication about the state via the buttons in #3318747: Change the default action for the Svelt UI for install controllers and screenreader users have the announcement suggested in #3318726: Reposition the card centric spinner for the Svelte UI for install controllers

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?
CommentFileSizeAuthor
install.jpg39.25 KBrkoller
download.jpg23.64 KBrkoller

Issue fork project_browser-3318750

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rkoller created an issue. See original summary.

rkoller’s picture

rkoller
he/him
Primary language German
Location Nürnberg, Germany
commented
Issue summary: View changes
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +core-mvp

Utkarsh_33 made their first commit to this issue’s fork.

Utkarsh_33 opened merge request !330

utkarsh_33’s picture

utkarsh_33 commented
Status: Active » Needs review
srishtiiee’s picture

srishtiiee commented
Status: Needs review » Needs work

Removing modals for successful download/install from the UI also implies that we remove the messages from the JSON response in the InstallerController as well, as those messages are no longer being used.

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review
srishtiiee’s picture

srishtiiee commented
Status: Needs review » Needs work
utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review
srishtiiee’s picture

srishtiiee commented
Status: Needs review » Reviewed & tested by the community
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: remove the successful download and or install modal for the Svelt UI for install controlers » Remove the successful download/install modal from the Svelte UI for install controllers

Retitling before merge

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

Merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.