[Drupal core] PHP Fatal error: Declaration of WebformEntityReferenceFormatterBase::getEntitiesToView

@podarok code is ok, but now it looks like we have to add additional code to the info file saying that Webform 6.1.3+ requires Drupal 9.4.
Or we could add it to the composer.
PR fixes the issue on fresh install with 9.4

Adding duplicate issue, will leave this as the primary.

@anpolimus I'm not sure if the requirements have changed, but Webform 6.1.3 requires Drupal ^9 but Webform ^6.2 requires Drupal ^9.4. This patch can work with either version, and coercing Webform to a different version can cause errors:

The following module is installed, but it is incompatible with Drupal 9.3.22:
Webform

I think we should remove the Drupal version change and leave that up to Webform to decide.

Fixed that up and rebased.

Reproduction steps:

- Install Drupal Core 9.4.5 (with Umami profile)
- Enable All messages at /admin/config/development/logging
- Require and enable Webform
- Edit a content type and add a Webform Reference field
- Upon trying to Save the Add field dialog, observe the error:

Fatal error: Declaration of Drupal\webform\Plugin\Field\FieldFormatter\WebformEntityReferenceFormatterBase::getEntitiesToView(Drupal\Core\Field\EntityReferenceFieldItemListInterface $items, $langcode) must be compatible with Drupal\Core\Field\Plugin\Field\FieldFormatter\EntityReferenceFormatterBase::getEntitiesToView(Drupal\Core\Field\FieldItemListInterface $items, $langcode) in /var/www/html/web/modules/contrib/webform/src/Plugin/Field/FieldFormatter/WebformEntityReferenceFormatterBase.php on line 60

I'm not able to recreate this with Drupal 10.0.1 and Webform 6.2, but not sure why as none of the related files seem to have changed.

I am very confused because I can't find a version of Drupal that references the FieldItemListInterface in EntityReferenceFormatterBase::getEntitiesToView

• https://git.drupalcode.org/project/drupal/-/blob/9.4.x/core/lib/Drupal/C...
• https://git.drupalcode.org/project/drupal/-/blob/9.5.x/core/lib/Drupal/C...
• https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/lib/Drupal/...

There is #3138528: getEntitiesToView() should implements the same interface as viewElements() , which does change the interface but has NOT been committed.

@froboy I see that you finding similar issues via #3229916: EntityReferenceFormatterBase::getEntitiesToView() must implement interface of EntityReferenceFieldItemListInterface, instance of AcquiaContentHubModerationStateFieldItemList given

@jrockowitz 🤦🏻‍♂️ I think I need environment_indicator on my DrupalPod. The environment in which I was able to reproduce the issue DID have the patch from #3138528: getEntitiesToView() should implements the same interface as viewElements() applied.

At this point it seems like that issue might be going a different direction, so I think we can mark this Postponed until the parent issue is somehow resolved. Sorry for the confusion and thanks for your time.

Thanks @jrockowitz
Removing the patch: #3138528: getEntitiesToView() should implements the same interface as viewElements() and updating core with `composer update --lock` fixed the "PHP Fatal error: Declaration of WebformEntityReferenceFormatterBase::getEntitiesToView" issue for me.

Removing the Drupal specific version number since this is a Drupal core related issue that has not being resolved.