Closed (fixed)
Project:
Coding Standards
Component:
Meeting
Priority:
Normal
Category:
Plan
Assigned:
Unassigned
Reporter:
Created:
23 Aug 2022 at 02:32 UTC
Updated:
4 Jul 2023 at 22:54 UTC
Jump to comment: Most recent
Hello all, it’s time for the fortnightly coding standards meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Usually happens fortnightly on Tuesday 2100 UTC. The meeting open for 24 hours to allow for all timezones.
➤ Is done on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
Standing items
- Who is here?
- What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.
- Action Items
- Approve previous minutes
- Wrap up
0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.
| quietone | Hi. |
0️⃣.5️⃣ Share something nice that happened for you in the past week
1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.
| quietone | Continuation of How to announce an issue for final discussion? |
| quietone | Creating standards for the GitLab CI templates, from @hestenet (he/him) |
| quietone | Issues to review for beta |
2️⃣ Action items
2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes!
| quietone | Getting some modules removed from core. |
| Björn Brala (bbrala) | Yeah, would share the same. Rdf is also about to get a release and I feel we should make the deadline for that one also. |
2️⃣.2️⃣ Approve last fortnight's minutes
| quietone | #3302317: Coding Standards Meeting 2022-08-16 2100 UTC |
3️⃣ Continuation of How to announce an issue for final discussion?
| quietone | I had hoped to follow this up and didn't get to it. |
| quietone | For now, I think this can be an Action item, until a resolution is found. |
| Björn Brala (bbrala) | Think d10 is owning us all a little |
| borisson_ | I think the biggest problem is that no one of us is a TWG member? |
| Björn Brala (bbrala) | The policy is very outdated, and with someone from the old TWG it will be easier to get things rolling. |
| Björn Brala (bbrala) | In last meeting gabor mentioned effulgentsia is the last active member it seems. But slack is not his things, so we mostly need to ask for help there. |
| borisson_ | I'm not sure if they will be at drupalcon next month, but that would be a great time to discuss this as well. |
| quietone | Yes, it would help to have comments on #3252921: Add members to and remove members from the Technical Working Group but we can still move things along. |
| Björn Brala (bbrala) | I think @quietone’s voice will get results fastest though. |
| quietone | I have spoken to xjm and had some brief contact with effulgentsia to fix credit (still not done correctly). So people are aware of our interest. And, I guess, like us Drupal 10 is the priority. |
4️⃣ Creating standards for the GitLab CI templates, from @hestenet (he/him)
| hestenet (he/him) | Hi everyone! As the GitLab Acceleration project continues we are eventually going to have one or more gitlab-ci.yml files that will need to represent best practice testing defaults. |
| hestenet (he/him) | This is something where the DA can do our best to kickstart things, but ultimately it would make sense for a working group to help own these. |
| quietone | Welcome @hestenet (he/him)! |
| quietone | Do you have some examples to start with? |
| hestenet (he/him) | Yes and no. We have some early work, but this is more of an upcoming thing. |
| hestenet (he/him) | Will try to share some examples when we can though. |
| hestenet (he/him) | And it may be something we can talk about sf DrupalCon for those who will be there. |
| hestenet (he/him) | #3265092: [META] Define a default .gitlab-ci.yml template that projects can inherit |
| quietone | That is a good idea. |
| quietone | Is the goal to have a guide in the Coding standards wiki, https://www.drupal.org/docs/develop/standards ? (edited) |
| quietone | Sorry, that should be 'is one of the goals to have a guide ...' |
| hestenet (he/him) | To have some form of best practices documentation yes. If not directly under coding standards than near it. I think testing standards and coding standards are cousins. :slightly_smiling_face: |
| quietone | There are pages about testing but none title 'testing standards'. Is there an existing page for 'testing standards'? |
| hestenet (he/him) | Good question.. I think not so much since the current DrupalCI is centrally managed, so the options are predefined. |
| hestenet (he/him) | But when we go to GitLab and people can define it themselves we'll likely want to put in place much stronger guidance. |
| hestenet (he/him) | And I think more than just docs, we'll also likely be looking for help with the maintainership of the yml templates themselves. |
| hestenet (he/him) | I'll do my best to gather more existing materials/docs/next steps between now and the conference so we can create a clearer picture of what's needed. |
| quietone | Looking forward to it. |
| quietone | Come back and share here anytime. |
| Björn Brala (bbrala) | Interested to see what has been created yeah. If we need module developers to add their own yml this will make getting tests running a little harder.Good docs will be essential, that at least is true. |
| borisson_ | Yes, I think adding our own .gitlab-ci.yml to all the modules will be difficult, but something like the project update bot can post a patch/mr so that's a good start I guess. I think the testing should at least have the same contents as what drupalci currently does? Is there a way to force people to have at least phpcs/phpunit even if they don't have a gitlab ci file? |
| borisson_ |
To have some form of best practices documentation yes. If not directly under coding standards than near it. I think testing standards and coding standards are cousins. I think they all are under TWG, and since that is basically the same people as the ones here we shouldn't make it too hard on our selves? |
| Björn Brala (bbrala) | Most of the technical discussion should be in #gitlab imo. |
| hestenet (he/him) |
I think they all are under TWG, and since that is basically the same people as the ones here we shouldn't make it too hard on our selves? I would tend to agree - which is why I wanted to chime in here. |
| hestenet (he/him) | This side of the conversation should be about ongoing maintainership and governance. |
5️⃣ Issues to review for beta
| quietone | Thanks to @klausi, one was RTBC but not back to NR for reviews. That should be simple, #2937515: Fix Drupal.Array.Array.[ArrayClosingIndentation, ArrayIndentation] coding standard |
| quietone | Also, thanks to @Niklan for keeping #3264947: [Sep 12, 2022] Add missing docblocks for test methods ::setUp() and ::tearDown() up to date. |
| quietone | Reminder to review the issues in the "Review for beta' folder at the top of the channel. |
6️⃣ Wrap UpThe meeting is open for 24 hours, Please continue to chat in the threads. A transcript is posted, usually within 1 week. (edited)
Participants:
Issue fork drupal-3305394
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #5
quietone commentedComment #7
spokje@shamir_shukla: Why opening an MR? What can be possibly be committed here? This is an issue about a meeting, absolutely no code needed.
Comment #8
quietone commented@samir_shukla, Welcome to Drupal! There are contributor tasks on Drupal.org that provide the steps for making useful additions to an issue. Creating an MR is not helpful here as explained in comment #7. Therefore, credit has been removed per How is credit granted for Drupal core issues.
There were no requests for changes to these minutes at the following meeting, therefore closing.
Comment #10
quietone commentedThis should be in the Coding Standards project.