Closed (fixed)
Project:
Project Browser
Version:
1.0.x-dev
Component:
Contrib changes
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Jul 2022 at 22:01 UTC
Updated:
21 Dec 2023 at 22:13 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
leslieg commentedComment #3
Siddhi_99 commentedComment #4
Siddhi_99 commentedTrim keyword represents to cut off small amount out of somethings, and as this feature is basically used for texts. So combining both the concepts. Here, are the few explorations around it.
Comment #5
Siddhi_99 commentedComment #6
SGhosh commentedComment #7
akshayadhav@Siddhi_99 The logos look good. Just make sure to reduce the file size as per the specifications provided in the parent issue.
Comment #8
urvashi_vora commentedHi,
Please review these logos.
Comment #9
ttamniwdoog commentedLike @AkshayAdhav mentioned and despite my preference for "Smart Trim.png", given the requirements, "Smart_trim_logo_2.png" and "Smart Trim.png" should be removed from further review.
Comment #10
ttamniwdoog commentedComment #11
starshapedWorking on this as part of NEDCamp 2022.
@urvashi_vora, the third logo you posted looks great! It fits the criteria of 512x512 and it's less than 10kb.
A couple little tweaks:
1. The light bulb icon looks a little off because it's positioned higher than the other icons in the logo. Is it possible to update this so that it appears more balanced?
2. Clean up the dashed lines that overlap the icons.
Comment #12
ressaAlso, I think the elements need to be less detailed and possibly scaled up, since they should work under smaller resolutions:
100x100px

Comment #13
markie commentedHi folks. As the maintainer of the smart_trim module, I am probably going to pick
Thank you for your work on this
Comment #14
markie commentedActually. I pulled chatted with the smart_date folks and I really like their logo so I am poaching their design, with their permission of course.
Taking feedback.
Comment #15
markie commentedComment #16
leslieg commentedMoving this back to needs work for someone to update the logo to meet the requirements for logo size for the logo in #14
Create a logo that is 512x512 square dimension in PNG format without animations. Suggested file size should be 10k or less. Use a lossy image tool (such as pngquant) to reduce file size while keeping the image quality at around 80%.
Comment #17
urvashi_vora commentedHi @leslieg, I have compressed the logo selected in #14.
Please review.
Thanks
Comment #18
chrisfromredfinThank you @urvashi_vora!
Comment #19
bramdriesenI'm triaging issues for the project browser initiative. This can be set to fixed as the logo has been committed, listing this on slack so a maintainer here can double check issue credits.
https://git.drupalcode.org/project/smart_trim/-/blob/2.1.x/logo.png?ref_...
Comment #20
bramdriesenComment #21
lostcarpark commentedThere's a small problem here, that it doesn't seem that #14 was checked for correct image dimensions, just file size.
The image is 415x481 pixels, so a little small. The other problem is it's not square.
I had already redrawn part of this logo for another project, so it was not much work to finish it off.
I have uploaded an updated version, which I believe meets the logo requirements.
I'm setting the issue back to "needs review".
Comment #22
urvashi_vora commentedThanks @lostcarpark
Comment #23
urvashi_vora commentedEverything looks good, setting it to RTBC.
Comment #24
bramdriesenCreated a follow up ticket with a MR: https://www.drupal.org/project/smart_trim/issues/3405937
Comment #25
bramdriesenAnd fixed ;-)
Comment #27
akshayadhav@BramDriesen I guess you missed adding credits to the people involved.
Comment #28
bramdriesenOnly a maintainer can do that. We're on this! ;-)
Comment #29
akshayadhavOh ok. No problem. I thought you were one of the maintainers.
Comment #30
leslieg commented