Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#20 3289911-20.patch3.08 KBjcnventura
#20 interdiff_9_20.txt352 bytesjcnventura
#9 3289911-9.patch3.08 KBjcnventura
#9 interdiff_8_9.txt3.76 KBjcnventura
#8 3289911-8.patch2.58 KBviappidu
#4 symfony_mailer.1.x-dev.rector.patch2.16 KBproject update bot
#4 interdiff-last-bot.6664190.txt72 bytesproject update bot
#3 symfony_mailer.1.x-dev.rector.patch2.16 KBproject update bot
#3 interdiff-last-bot.6645507.txt1.36 KBproject update bot
#2 symfony_mailer.1.x-dev.rector.patch879 bytesproject update bot

Issue fork symfony_mailer-3289911

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • d10 Comparecompare
About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new symfony_mailer.1.x-dev.rector.patch879 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6645507.txt1.36 KB
new symfony_mailer.1.x-dev.rector.patch2.16 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6664190.txt72 bytes
new symfony_mailer.1.x-dev.rector.patch2.16 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #143

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

  • AdamPS committed 4d1ce55 on 1.x 
    Issue #3289911 by Project Update Bot: Automated Drupal 10 compatibility...
adamps’s picture

adamps commented
Issue summary: View changes
Status: Needs review » Active
viappidu’s picture

viappidu commented
StatusFileSize
new 3289911-8.patch2.58 KB

It works, possibly a newer rector will find something more...

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new interdiff_8_9.txt3.76 KB
new 3289911-9.patch3.08 KB

invokeAllWith was only introduced in Drupal 9.4. Also, test modules should not declare a core_version_requirement, but instead be part of teh "Testing" package. And since I'm not sure if current support for symfony/mailer 5.3 needs to be dropped, better add the support for 6.1 as an option.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Those look good for 1.1.x branch

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented

Yes patch seems to work.
Would be good to get a Drupal 10 release soon of this module, to not block updates to Drupal 10.

adamps’s picture

adamps commented

Great thanks.

symfony/mailer:5.4 is still needed because 6.x requires PHP 8.1, whereas Drupal 9 allows 7.4/8.0.

1) Any reason against symfony/mailer:6.0?

2) Drupal 9.3 ceased to have security coverage on December 14th, however 9.3.22 is still in use on 7000 sites. I guess it's OK, because composer will refuse to offer the new release of symfony_mailer for sites still on D9.3. Can anyone confirm please? We should at least flag this in the release note.

ptmkenny made their first commit to this issue’s fork.

ptmkenny’s picture

ptmkenny commented

Opened an MR with jcventura's patch in #11 applied so that the module can be installed for testing in d10 sites and upgrading sites before this is committed.

"repositories": {
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/symfony_mailer"
            ]
        },
        {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/symfony_mailer-3289911.git"
        },

And then composer require "drupal/symfony_mailer:dev-d10".

More info in the docs.

rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Normal » Major
rajab natshah’s picture

rajab natshah
he/him
commented

Thanks, Adam, for having time to build this important needed module
Hoping for a tag release. To ease the testing work.
Testing now with the 1.x-dev development branch

adamps’s picture

adamps commented
Status: Reviewed & tested by the community » Needs work

Any reason against symfony/mailer:6.0?

(Question still open from #12)

Would be good to get a Drupal 10 release soon of this module, to not block updates to Drupal 10.

Hoping for a tag release.

I can make a new release once the question has been answered. I will make a 1.2 release to make things clearer for anyone still on D9.3.

jcnventura’s picture

jcnventura
Primary language English
commented

@AdamPS:

On 1., when I did #9, I simply reused the existing symfony/mailer 6.1 requirement from #8. According to https://symfony.com/releases, both 6.0 and 6.1 will both be unsupported in a few days, but that is not really a reason for not allowing ^6.0, so we can certainly use ^5.3 || ^6.0.

On 2., indeed 9.3.x is no longer supported (see https://www.drupal.org/about/core/policies/core-release-cycles/schedule). Any release using the proposed core_version_requirement of ^9.4 || ^10 will not be installed when using composer in 9.3.x sites. With the current tags, this means that 1.1.0-beta3 would be the last one installable on Drupal 9.1.x, 9.2.x and 9.3.x.

Fully agreed with this being 1.2.0-beta1.

adamps’s picture

adamps commented

so we can certainly use ^5.3 || ^6.0.

Yes please, just in case it helps a few sites that prefer to lock a specific version of symfony that has already been tested. If you can do that, I'll make the release ASAP.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff_9_20.txt352 bytes
new 3289911-20.patch3.08 KB

As requested.

adamps’s picture

adamps commented
Status: Needs review » Fixed

Great thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.