Deprecate Symfony 4 RequestStack BC shim for removal in D11

--- Errors ---
PHP Fatal error:  Uncaught Error: Call to undefined method Symfony\Component\HttpFoundation\RequestStack::getMainRequest() in /var/www/html/core/lib/Drupal/Core/DrupalKernel.php:935
Stack trace:
#0 /var/www/html/core/lib/Drupal/Core/DrupalKernel.php(472): Drupal\Core\DrupalKernel->initializeContainer()
#1 /var/www/html/core/lib/Drupal/Core/Test/TestRunnerKernel.php(75): Drupal\Core\DrupalKernel->boot()
#2 /var/www/html/core/scripts/run-tests.sh(561): Drupal\Core\Test\TestRunnerKernel->boot()
#3 /var/www/html/core/scripts/run-tests.sh(51): simpletest_script_init()
#4 {main}
  thrown in /var/www/html/core/lib/Drupal/Core/DrupalKernel.php on line 935

fwiw I think #3209617-21: [Symfony 6] Symfony\Component\HttpFoundation\RequestStack::getMasterRequest() is deprecated, use getMainRequest() instead is still right, it lets 9.4.x-compatible modules start using the Symfony 5/6 API in 9.4, but then once they're using in 9.4, we don't want to break them in 10.x if they use the shim directly, so deprecating for removal 11.x works.

Agree with removing the support for getMasterRequest() from 10.x, which is already in the MR.

As I got catch we should just deprecate in D10 for removal in D11, so you need to revert change to masterRequest and just update its deprecation message to include a link to https://www.drupal.org/node/3253744

I mean the already deprecated getMasterRequest() should be removed in D10 sametime as the shim deprecated

Here's my vision

Thank you! nice catch!

btw there's only 2 references explaining how to provide link to removal https://www.drupal.org/about/core/policies/core-change-policies/drupal-d...

+++ b/core/lib/Drupal/Core/Http/RequestStack.php
@@ -19,20 +26,8 @@ class RequestStack extends SymfonyRequestStack {
+    @trigger_error('The ' . __NAMESPACE__ . '\RequestStack is deprecated in drupal:10.0.0 and is removed from drupal:11.0.0. There is no replacement. See https://www.drupal.org/node/3265357', E_USER_DEPRECATED);
+    return parent::getMainRequest();

I wonder if we really need to deprecate this method or if we can just have an empty class. Its seems likely to trigger in correct code that's having the wrong class injected.

Anyways, that's not a critical change. With the @todo fixed to 11 I think this is an easy RTBC.

Filed follow-up for 9.4.x #3265419: Improve deprecation message for RequestStack::getMasterRequest()

@neclimdul Re#26 the reason to provide this message is to catch unit-tests which used to call the method, no idea if class load is enough

So I think the other option here just to make phpstan quiet would have been to remove the ::getMasterRequest() method without deprecating.

That would mean we'd need a follow-up to deprecate in 10.1.x to remove in 11.x, but ::getMasterRequest() is only used by a handful of modules in contrib: http://grep.xnddx.ru/search?text=getMasterRequest&filename= - and a similarly small number that directly use Symfony's RequestStack. Only the intersection of the two (which I did not check, but must be lower) would be affected by the deprecation here.

So I think the number of contrib modules that will need to actually use the shim in 9.4.x will be very low, meaning the number affected by it being deprecated in Drupal 10.0.x will also be very low.

We can't deprecated it in 9.4.x for removal in 11.x because we don't have the new RequestStack object available yet, and also because core uses it.

Committed bc964dc and pushed to 10.0.x. Thanks!

Added related #3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch