Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Feb 2022 at 23:03 UTC
Updated:
16 Mar 2024 at 22:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
longwaveComment #4
andypostComment #5
andypostRemoved legacy test and fixed mentions
Comment #6
andypostFYI
RendererPlaceholdersTesthas local failures because of stricter types on PHP 8The
\Drupal\Core\Render\Renderer::doCallbackneeds to relax second argument "array" type to allow pass tests or this tests and assertions could be removedComment #7
spokjeFCI (=For Committers Information): A full PHPStan run on this one would be nice, since it currently makes patches/MRs that change the baseline fail (#3227033-128: Remove Quick Edit from core and #3227033-130: Remove Quick Edit from core)
Comment #8
spokjeGreen TestBot and neither it nor me could find any other references to the shim.
RTBC for me.
Comment #9
andypostFiled follow-up #3265288: Add assertion for #lazy_builder callback argument
Comment #10
neclimdulDon't really want to leave this empty class lying around for a full release cycle but I'm not sure we can remove the entire class without deprecating it can we? The class would be expected to exist. Facets is at least still using it.
Comment #11
spokjeOuch....Everybody must have seen so much "Remove All The Deprecation Things!"-issues by now that we've become blind to the fact that not everything is nicely deprecated already.
Let's deprecate this in
9.4.x10.0.xbefore we remove.I've opened #3265356: Deprecate Symfony 4 RequestStack BC shim for removal in D11 for that and am postponing this issue on it.
Thanks @necliimdul for being eagle-eyed and spotting this.
Comment #12
spokjePostponed until
11.0.x-devis open.Comment #13
spokjeComment #14
andypostSetting postponed til 11.0.x open according to #3265356-35: Deprecate Symfony 4 RequestStack BC shim for removal in D11
Comment #15
andypostComment #16
andypostsorry it's for 11.x
Comment #17
andypostComment #18
quietone commentedMoving to 11.x-dev
Comment #19
andypostComment #21
sakthi_dev commentedIt's already changed in 11.x. Please correct me if I'm wrong.
Comment #22
andypostIt needs to remove remain after https://git.drupalcode.org/project/drupal/-/commit/bc964dc
Comment #23
andypostIt just needs
rm core/lib/Drupal/Core/Http/RequestStack.php core/tests/Drupal/Tests/Core/Http/RequestStackLegacyTest.phpComment #25
andypostlet's see if that enough
Comment #26
smustgrave commentedSearched for \Core\Http\RequestStack and only found in that test that was deleted.
So removal seemed good.
Comment #27
longwaveCommitted 60d5162 and pushed to 11.x. Thanks!