Problem/Motivation

Follow-up to #3209617: [Symfony 6] Symfony\Component\HttpFoundation\RequestStack::getMasterRequest() is deprecated, use getMainRequest() instead discovered in #3265356: Deprecate Symfony 4 RequestStack BC shim for removal in D11

The deprecation message should follow standard https://www.drupal.org/about/core/policies/core-change-policies/drupal-d...

Proposed resolution

Set message to required with link to change record https://www.drupal.org/node/3253744 and fix test

Remaining tasks

review/commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

no

CommentFileSizeAuthor
#2 3265419-2.patch1.84 KBandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Component: base system » request processing system
Status: Active » Needs review
Issue tags: +Symfony 6
Parent issue: #3209617: [Symfony 6] Symfony\Component\HttpFoundation\RequestStack::getMasterRequest() is deprecated, use getMainRequest() instead » #3161889: [META] Symfony 6 compatibility
StatusFileSize
new 3265419-2.patch1.84 KB
spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

Molding the deprecation message to fit into the standard and adding a link to a CR always looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 3c7c0fdfc3d to 9.4.x and 31d2dc98dfa to 9.3.x. Thanks!

Backported to 9.3.x since it is helpful there too.

  • alexpott committed 3c7c0fd on 9.4.x 
    Issue #3265419 by andypost: Improve deprecation message for RequestStack...

  • alexpott committed 31d2dc9 on 9.3.x 
    Issue #3265419 by andypost: Improve deprecation message for RequestStack...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.