Problem/Motivation

Fix coding standards problems in the module

FILE: modules/contrib/upgrade_status/src/Util/DatabaseServerMetadataExtractor.php
----------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Missing class doc comment
11 | ERROR | [x] Doc comment short description must end with a full stop
113 | ERROR | [x] Expected 1 blank line after function; 0 found
114 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/ExtensionMetadataDeprecationAnalyzer.php
----------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------
20 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
60 | WARNING | [ ] '@todo' should match the format '@todo Fix problem X here.'
73 | ERROR | [x] Expected newline after closing brace
110 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
118 | ERROR | [x] Expected 1 space before "|"; 0 found
118 | ERROR | [x] Expected 1 space after "|"; 0 found
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/ScanResultFormatter.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 14 ERRORS AND 7 WARNINGS AFFECTING 17 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
90 | ERROR | [x] Separate the @param and @return sections by a blank line.
120 | WARNING | [x] A comma should follow the last multiline array item. Found: )
174 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
185 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
187 | WARNING | [x] There must be no blank line following an inline comment
187 | WARNING | [ ] There must be no blank line following an inline comment
203 | ERROR | [ ] The array declaration extends to column 116 (the limit is 80). The array content should be split up over multiple lines
211 | ERROR | [ ] join() is a function name alias, use implode() instead
244 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
265 | ERROR | [ ] The array declaration extends to column 323 (the limit is 80). The array content should be split up over multiple lines
284 | WARNING | [x] A comma should follow the last multiline array item. Found: )
336 | ERROR | [ ] join() is a function name alias, use implode() instead
418 | ERROR | [x] Expected 1 space after "=>"; 2 found
418 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
426 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
477 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
478 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
479 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
479 | WARNING | [x] A comma should follow the last multiline array item. Found: )
499 | ERROR | [ ] join() is a function name alias, use implode() instead
499 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/RouteDeprecationAnalyzer.php
----------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------
18 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
51 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
59 | ERROR | [x] Expected 1 space before "|"; 0 found
59 | ERROR | [x] Expected 1 space after "|"; 0 found
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/ProjectCollector.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 7 WARNINGS AFFECTING 13 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
211 | ERROR | [x] Use null coalesce operator instead of ternary operator.
215 | WARNING | [x] There must be no blank line following an inline comment
215 | WARNING | [ ] There must be no blank line following an inline comment
286 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
333 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
337 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
341 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
366 | ERROR | [ ] The array declaration extends to column 180 (the limit is 80). The array content should be split up over multiple lines
467 | ERROR | [x] Expected "null|string" but found "NULL|string" for function return type
536 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead
552 | ERROR | [ ] Description for the @return value is missing
570 | ERROR | [ ] Description for the @return value is missing
572 | ERROR | [ ] Public method name "ProjectCollector::isCompatibleWithPHP8" is not in lowerCamel format
589 | ERROR | [x] Case breaking statements must be followed by a single blank line
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/Commands/UpgradeStatusCommands.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 7 WARNINGS AFFECTING 11 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
14 | ERROR | [x] Doc comment short description must end with a full stop
87 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
89 | ERROR | [ ] The array declaration extends to column 224 (the limit is 80). The array content should be split up over multiple lines
93 | WARNING | [ ] Unused variable $type.
144 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
146 | ERROR | [ ] The array declaration extends to column 221 (the limit is 80). The array content should be split up over multiple lines
149 | WARNING | [ ] Unused variable $type.
185 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
187 | ERROR | [ ] The array declaration extends to column 223 (the limit is 80). The array content should be split up over multiple lines
254 | WARNING | [ ] Unused variable $type.
257 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/Controller/ScanResultController.php
-----------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 8 LINES
-----------------------------------------------------------------------------------------------------
13 | ERROR | [x] Missing class doc comment
101 | ERROR | [x] Expected 1 space between double arrow and "'upgrade_status_'"; 2 found
101 | ERROR | [x] Expected 1 space after "=>"; 2 found
101 | ERROR | [x] There should be no white space before a closing "]"
104 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
105 | ERROR | [x] Array indentation error, expected 6 spaces but found 10
106 | ERROR | [x] Array indentation error, expected 6 spaces but found 10
106 | ERROR | [x] Expected 0 spaces between ")" and comma; 1 found
138 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
143 | ERROR | [x] Expected 1 blank line after function; 0 found
144 | ERROR | [x] The closing brace for the class must have an empty line before it
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/Form/UpgradeStatusForm.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 43 ERRORS AND 49 WARNINGS AFFECTING 80 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
30 | ERROR | [x] Missing class doc comment
143 | ERROR | [ ] Parameter $database is not described in comment
166 | ERROR | [ ] Doc comment for parameter $connection does not match actual variable name $kernel
238 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
278 | ERROR | [ ] The array declaration extends to column 108 (the limit is 80). The array content should be split up over multiple lines
278 | ERROR | [ ] The array declaration extends to column 107 (the limit is 80). The array content should be split up over multiple lines
284 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
328 | ERROR | [ ] The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines
329 | ERROR | [ ] The array declaration extends to column 106 (the limit is 80). The array content should be split up over multiple lines
329 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
329 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
330 | ERROR | [ ] The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines
331 | ERROR | [ ] The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
332 | ERROR | [ ] The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines
332 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
332 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
333 | ERROR | [ ] The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
388 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
396 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
406 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
415 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
465 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
485 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
495 | ERROR | [x] Case breaking statements must be followed by a single blank line
499 | ERROR | [x] Case breaking statements must be followed by a single blank line
520 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
529 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
541 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
550 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
594 | ERROR | [ ] The array declaration extends to column 137 (the limit is 80). The array content should be split up over multiple lines
595 | ERROR | [ ] The array declaration extends to column 138 (the limit is 80). The array content should be split up over multiple lines
596 | ERROR | [ ] The array declaration extends to column 126 (the limit is 80). The array content should be split up over multiple lines
608 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
609 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
614 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
617 | WARNING | [ ] Unused variable $name.
625 | WARNING | [ ] Line exceeds 80 characters; contains 105 characters
628 | ERROR | [ ] The array declaration extends to column 309 (the limit is 80). The array content should be split up over multiple lines
628 | WARNING | [x] A comma should follow the last multiline array item. Found: )
713 | ERROR | [ ] The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines
733 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
741 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
741 | ERROR | [ ] The array declaration extends to column 138 (the limit is 80). The array content should be split up over multiple lines
742 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
742 | ERROR | [ ] The array declaration extends to column 146 (the limit is 80). The array content should be split up over multiple lines
773 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
798 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
827 | WARNING | [x] A comma should follow the last multiline array item. Found: $requirement
834 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
844 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
864 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
870 | WARNING | [ ] Role::loadMultiple calls should be avoided in classes, use dependency injection instead
871 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
901 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
911 | ERROR | [ ] join() is a function name alias, use implode() instead
926 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
936 | ERROR | [ ] The array declaration extends to column 559 (the limit is 80). The array content should be split up over multiple lines
946 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
954 | ERROR | [x] Array indentation error, expected 12 spaces but found 14
954 | ERROR | [ ] The array declaration extends to column 136 (the limit is 80). The array content should be split up over multiple lines
955 | ERROR | [x] Array indentation error, expected 12 spaces but found 14
955 | ERROR | [ ] The array declaration extends to column 144 (the limit is 80). The array content should be split up over multiple lines
986 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
1009 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
1078 | WARNING | [x] A comma should follow the last multiline array item. Found: $requirement
1085 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
1089 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
1117 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
1147 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
1178 | WARNING | [x] A comma should follow the last multiline array item. Found: $requirement
1185 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
1194 | ERROR | [x] Expected 1 blank line after function; 2 found
1238 | ERROR | [x] list(...) is forbidden, use [...] instead.
1238 | WARNING | [ ] Unused variable $error.
1241 | ERROR | [ ] The array declaration extends to column 156 (the limit is 80). The array content should be split up over multiple lines
1253 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
1308 | ERROR | [x] Concat operator must be surrounded by a single space
1309 | WARNING | [x] A comma should follow the last multiline array item. Found: $extensions
1329 | ERROR | [ ] Public method name "UpgradeStatusForm::exportReportASCII" is not in lowerCamel format
1345 | ERROR | [ ] Type hint "array" missing for $context
1354 | ERROR | [x] list(...) is forbidden, use [...] instead.
1354 | WARNING | [ ] Unused variable $data.
1368 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
1389 | ERROR | [ ] Missing parameter type
1391 | ERROR | [ ] Missing parameter type
1425 | WARNING | [x] A comma should follow the last multiline array item. Found: $project_machine_name
1483 | ERROR | [x] Expected "bool|null" but found "bool|NULL" for function return type
1493 | WARNING | [ ] Unused variable $config.
1494 | WARNING | [ ] Unused variable $databases.
1495 | WARNING | [ ] Unused variable $class_loader.
1501 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 48 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/DeprecationMessage.php
----------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------
52 | ERROR | Description for the @return value is missing
61 | ERROR | Description for the @return value is missing
70 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/LibraryDeprecationAnalyzer.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 34 ERRORS AND 2 WARNINGS AFFECTING 32 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
62 | ERROR | [x] Doc comment short description must end with a full stop
87 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
113 | ERROR | [ ] Description for the @return value is missing
118 | ERROR | [ ] Unnecessarily gendered language in a comment
133 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
165 | ERROR | [ ] Missing parameter comment
167 | ERROR | [ ] Description for the @return value is missing
168 | ERROR | [x] Separate the @return and @throws sections by a blank line.
178 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
178 | ERROR | [x] Expected 1 space after USE keyword; found 0
201 | ERROR | [ ] Missing parameter comment
203 | ERROR | [ ] Description for the @return value is missing
204 | ERROR | [x] Separate the @return and @throws sections by a blank line.
214 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
214 | ERROR | [x] Expected 1 space after USE keyword; found 0
241 | ERROR | [ ] Missing parameter comment
243 | ERROR | [ ] Description for the @return value is missing
271 | ERROR | [x] Expected newline after closing brace
282 | ERROR | [ ] Missing parameter comment
284 | ERROR | [ ] Description for the @return value is missing
304 | ERROR | [x] Expected newline after closing brace
320 | ERROR | [ ] Missing parameter comment
322 | ERROR | [ ] Description for the @return value is missing
333 | WARNING | [ ] The use of function fnmatch() is discouraged
338 | ERROR | [x] Expected newline after closing brace
346 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
347 | ERROR | [x] list(...) is forbidden, use [...] instead.
347 | WARNING | [ ] Unused variable $type.
353 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
355 | ERROR | [x] list(...) is forbidden, use [...] instead.
363 | ERROR | [x] list(...) is forbidden, use [...] instead.
371 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
371 | ERROR | [x] Expected 1 space after USE keyword; found 0
406 | ERROR | [x] Expected "bool|string|null|DeprecationMessage" but found "bool|string|NULL|DeprecationMessage" for function return type
414 | ERROR | [x] list(...) is forbidden, use [...] instead.
418 | ERROR | [ ] Unnecessarily gendered language in a comment
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 21 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/TwigDeprecationAnalyzer.php
---------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
19 | ERROR | [x] Missing function doc comment
29 | ERROR | [ ] Description for the @return value is missing
55 | ERROR | [ ] Missing parameter type
58 | ERROR | [ ] Description for the @return value is missing
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/ThemeFunctionDeprecationAnalyzer.php
-------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
-------------------------------------------------------------------------------------------------------------
37 | ERROR | [ ] Parameter $container is not described in comment
40 | ERROR | [ ] Doc comment for parameter $this->container does not match actual variable name $container
53 | ERROR | [ ] Description for the @return value is missing
78 | ERROR | [x] Expected newline after closing brace
95 | ERROR | [ ] Missing parameter type
100 | ERROR | [ ] Description for the @return value is missing
107 | ERROR | [x] Expected newline after closing brace
115 | ERROR | [x] Expected newline after closing brace
143 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
158 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/DeprecationAnalyzer.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 9 WARNINGS AFFECTING 15 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
15 | ERROR | [x] Missing class doc comment
120 | ERROR | [ ] Class property $CSSDeprecationAnalyzer should use lowerCamel naming without underscores
340 | ERROR | [ ] Function return type is not void, but function does not have a non-void return statement
367 | WARNING | [x] A comma should follow the last multiline array item. Found: $project_dir
377 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7
381 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7
382 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7
393 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
435 | WARNING | [ ] Unused variable $path.
623 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
637 | ERROR | [ ] Description for the @return value is missing
699 | WARNING | [ ] Line exceeds 80 characters; contains 170 characters
699 | ERROR | [x] No space found before comment text; expected "// 'Call to deprecated method l() of class [redacted]. Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Use
| | Drupal\Core\Link::fromTextAndUrl() instead.'," but found "//'Call to deprecated method l() of class [redacted]. Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Use
| | Drupal\Core\Link::fromTextAndUrl() instead.',"
699 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
703 | WARNING | [x] There must be no blank line following an inline comment
703 | WARNING | [ ] There must be no blank line following an inline comment
716 | WARNING | [x] There must be no blank line following an inline comment
716 | WARNING | [ ] There must be no blank line following an inline comment
794 | ERROR | [x] Language constructs must be followed by a single space; expected 1 space but found "\n"
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/src/CSSDeprecationAnalyzer.php
-----------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------------------
15 | ERROR | [x] Expected 3 space(s) before asterisk; 4 found
18 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
49 | ERROR | [ ] Private method name "CSSDeprecationAnalyzer::getAllCSSFiles" is not in lowerCamel format
51 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
54 | ERROR | [x] Expected 1 space before "|"; 0 found
54 | ERROR | [x] Expected 1 space after "|"; 0 found
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/upgrade_status.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/src/Functional/UpgradeStatusUiTest.php
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------
58 | WARNING | Line exceeds 80 characters; contains 83 characters
65 | WARNING | Line exceeds 80 characters; contains 94 characters
----------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/src/Functional/UpgradeStatusAnalyzeTest.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------
12 | ERROR | [x] Missing function doc comment
183 | WARNING | [ ] Line exceeds 80 characters; contains 103 characters
185 | WARNING | [ ] Line exceeds 80 characters; contains 135 characters
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/src/Kernel/TwigDeprecationAnalyzerTest.php
--------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------
15 | ERROR | [ ] Missing member variable doc comment
20 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_contrib_error/src/Controller/UpgradeStatusTestContribErrorController.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
12 | ERROR | [x] Missing function doc comment
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_contrib_error/upgrade_status_test_contrib_error.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_contrib_error/upgrade_status_test_contrib_error.module
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 9 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
6 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it
10 | ERROR | [ ] The trigger_error message 'upgrade_status_test_contrib_error_function_8_to_9() is deprecated in Drupal 8.6.0 and will be removed before Drupal 9.0.0. Use the replacement instead. See
| | LINK' does not match the strict standard format: %thing% is deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link%
16 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it
20 | ERROR | [ ] The trigger_error message 'upgrade_status_test_contrib_error_function_8_to_10() is deprecated in Drupal 8.6.0 and will be removed before Drupal 10.0.0. Use the replacement instead. See
| | LINK' does not match the strict standard format: %thing% is deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link%
26 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it
30 | ERROR | [ ] The trigger_error message 'upgrade_status_test_contrib_error_function_9_to_10() is deprecated in Drupal 9.4.0 and will be removed before Drupal 10.0.0. Use the replacement instead. See
| | LINK' does not match the strict standard format: %thing% is deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link%
36 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it
40 | ERROR | [ ] The trigger_error message 'upgrade_status_test_contrib_error_function_9_to_11() is deprecated in Drupal 9.0.0 and will be removed before Drupal 11.0.0. Use the replacement instead. See
| | LINK' does not match the strict standard format: %thing% is deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_submodules/upgrade_status_test_submodules.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_submodules/modules/upgrade_status_test_submodules_a/upgrade_status_test_submodules_a.info.yml
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_contrib_9_compatible/upgrade_status_test_contrib_9_compatible.info.yml
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
----------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_library/upgrade_status_test_library.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_library/upgrade_status_test_library.module
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_twig/src/TwigExtension/DeprecatedFilter.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Missing class doc comment
9 | ERROR | [x] Missing function doc comment
9 | ERROR | [x] Expected 1 blank line before function; 0 found
11 | ERROR | [x] Expected 1 blank line after function; 0 found
12 | ERROR | [x] The closing brace for the class must have an empty line before it
-------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_twig/upgrade_status_test_twig.info.yml
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_theme_functions/upgrade_status_test_theme_functions.info.yml
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_theme_functions/upgrade_status_test_theme_functions.module
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
9 | WARNING | [x] A comma should follow the last multiline array item. Found: 'upgrade_status_test_theme_function'
27 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "upgrade_status_test_theme_function" but expected
| | "upgrade_status_test_theme_functions_upgrade_status_test_theme_function"
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_error/src/DeprecatedBaseClass.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Each @deprecated tag must have a @see tag immediately following it
---------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_error/src/Controller/UpgradeStatusTestErrorController.php
---------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------------
12 | ERROR | [x] Missing function doc comment
---------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_error/upgrade_status_test_error.css
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | Class definition is empty
5 | ERROR | Class definition is empty
9 | ERROR | Class definition is empty
-----------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_error/fatal.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_error/upgrade_status_test_error.info.yml
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
----------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_library_exception/upgrade_status_test_library_exception.info.yml
----------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
----------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_9_compatible/upgrade_status_test_9_compatible.info.yml
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_deprecated/upgrade_status_test_deprecated.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------------------------------------------------------------------------

FILE: ...l9new/modules/contrib/upgrade_status/tests/modules/upgrade_status_test_submodules_with_error/modules/upgrade_status_test_submodules_with_error_a/upgrade_status_test_submodules_with_error_a.info.
yml
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_submodules_with_error/upgrade_status_test_submodules_with_error.info.yml
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_10_compatible/upgrade_status_test_10_compatible.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/modules/upgrade_status_test_10_compatible/node_modules/upgrade_status_test_10_compatible.inc
----------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
3 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/themes/upgrade_status_test_theme/upgrade_status_test_theme.theme
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------

FILE: modules/contrib/upgrade_status/tests/themes/upgrade_status_test_theme/upgrade_status_test_theme.info.yml
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
---------------------------------------------------------------------------------------------------------------------------------------

Time: 1.94 secs; Memory: 20MB

Steps to reproduce

Run phpcs
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml upgrade_status/

Proposed resolution

Fix the issues

Remaining tasks

Send a patch
Test it
Commit

User interface changes

_

API changes

_

Data model changes

_

CommentFileSizeAuthor
#10 3260674-10.patch69.72 KBtmaiochi
#6 3260674-6.patch61.16 KBtmaiochi
#3 3260674-3.patch61.13 KBtmaiochi

Comments

tmaiochi created an issue. See original summary.

tmaiochi’s picture

Working on it.

tmaiochi’s picture

Assigned: tmaiochi » Unassigned
Status: Active » Needs review
StatusFileSize
new61.13 KB
lucienchalom’s picture

Status: Needs review » Needs work

The patch is not applying, problems on file Form/UpgradeStatusForm and ProjectCollector

tmaiochi’s picture

Assigned: Unassigned » tmaiochi

I'll do a re-roll.

tmaiochi’s picture

Status: Needs work » Needs review
StatusFileSize
new61.16 KB

This is the reroll

tmaiochi’s picture

Assigned: tmaiochi » Unassigned
lucienchalom’s picture

Status: Needs review » Needs work

The patch applies now, and I also applied #3260585: Add Documentation in this module following PHPCS messages so documentation would not conflict.
But there is a long list of files with new documentation problems even when excluding the files form #3260585-8: Add Documentation in this module following PHPCS messages.
These are the files ta needs changes:
ScanResultController.php
DeprecationAnalyzer.php
UpgradeStatusForm.php
ThemeFunctionDeprecationAnalyzer.php
TwigDeprecationAnalyzer.php
UpgradeStatusAnalyzeTest.php
TwigDeprecationAnalyzerTest.php

These are the files that would break the tests:
upgrade_status_test_contrib_error.module
DeprecatedBaseClass.php
UpgradeStatusTestContribErrorController.php
upgrade_status_test_theme_functions.module
upgrade_status_test_library.module
fatal.php
UpgradeStatusTestErrorController.php
upgrade_status_test_theme.theme
upgrade_status_test_contrib_error.info.yml
upgrade_status_test_contrib_9_compatible.info.yml

Also, this issue is way too big, so I would like to suggest cutting it again by group of files.

tmaiochi’s picture

Title: Fix coding standards » Fix coding standards on src
Assigned: Unassigned » tmaiochi

I'll do this, and as you suggested I created new issues to cut this issue by group of file in #3261776: Fix coding standards in the root folder and #3261778: Fix coding standards on tests. Thanks @lucienchalom

tmaiochi’s picture

Assigned: tmaiochi » Unassigned
Status: Needs work » Needs review
StatusFileSize
new69.72 KB

This is a new patch with all coding standards fixed in files on src folder, except for dependency injection that was fixed in #3260408: Fix missing dependency injections.

lucienchalom’s picture

Status: Needs review » Reviewed & tested by the community

all the coding standards problems were properly removed, as said on #10 there is only the DI left.
the module is still running too.
Thank you

gábor hojtsy’s picture

Status: Reviewed & tested by the community » Postponed

This does contain at least part of #3260408: Fix missing dependency injections I think in the drush command, so let's do this after #3260408: Fix missing dependency injections (which itself is easier to review).

avpaderno’s picture

Title: Fix coding standards on src » Fix the issues reported by phpcs
Issue tags: +Coding standards, +Needs issue summary update
indrapatil’s picture

Issue summary: View changes
avpaderno’s picture

gábor hojtsy’s picture

Title: Fix the issues reported by phpcs » Fix the issues reported by phpcs in the src folder

This was specifically about the src folder, so let't not loose that information from the title.

indrapatil’s picture

Issue summary: View changes
gábor hojtsy’s picture

Status: Postponed » Closed (duplicate)

This was fixed just now in #3459216: Fix all phpcs issues will credit you all there.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.