Closed (duplicate)
Project:
Upgrade Status
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
19 Jan 2022 at 11:12 UTC
Updated:
23 Feb 2026 at 10:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
tmaiochi commentedI'll work on this!
Comment #3
tmaiochi commentedI was not able to fix some warnings about deprecated links, and I don't know what those links are. But all the other things were fixed.
Comment #4
gábor hojtsyThanks for working on this!
Did you generate this patch with hand or automatically with something? There are lots of types of changes here, it would be best to somehow group them together, which would be reviewable. Eg most info file changes look good with a couple exceptions, but several PHP changes look dubious.
Comment #5
tmaiochi commentedHi @Gábor Hojtsy, I fixed somethings automatically with PHPCBF, and others that weren't fixed, I did it manually. If you want I can group the patches by folders. Just let me know!
Comment #6
gábor hojtsyI think it would be best to try by type of fix, eg. info files, make sure the tests still pass, etc.
Comment #7
tmaiochi commentedI'll work on that
Comment #8
tmaiochi commentedHi @Gábor Hojtsy, I'll create some child issues for this, and change to meta. I'll create one to dependency injection, one for info files, and I'm thinking in create one to documentation and another to coding standards, what do you think?
Comment #9
gábor hojtsyComment #10
viniciuscosta commentedI can't apply the 3259328-3.patch.
Comment #11
Neeraj333 commentedI am working on this.
Comment #12
Neeraj333 commentedI have fixed some coding standards errors request you to please verify it.
Comment #13
arti_parmar commentedComment #14
arti_parmar commentedI have applied a patch for "[META] Fix coding standards problems in the module", kindly review patch.
Comment #15
gábor hojtsyThese were fixed in #3459216: Fix all phpcs issues, going to credit you all there and marking this as duplicate.