Problem/Motivation

Fix coding standards problems in the module

Steps to reproduce

Run phpcs

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

Proposed resolution

Fix the problems

Remaining tasks

Send a patch
Test it
Commit

User interface changes

_

API changes

_

Data model changes

_

Comments

hmendes created an issue. See original summary.

tmaiochi’s picture

Assigned: Unassigned » tmaiochi

I'll work on this!

tmaiochi’s picture

Assigned: tmaiochi » Unassigned
Status: Active » Needs review
StatusFileSize
new100.02 KB

I was not able to fix some warnings about deprecated links, and I don't know what those links are. But all the other things were fixed.

gábor hojtsy’s picture

Thanks for working on this!

Did you generate this patch with hand or automatically with something? There are lots of types of changes here, it would be best to somehow group them together, which would be reviewable. Eg most info file changes look good with a couple exceptions, but several PHP changes look dubious.

tmaiochi’s picture

Hi @Gábor Hojtsy, I fixed somethings automatically with PHPCBF, and others that weren't fixed, I did it manually. If you want I can group the patches by folders. Just let me know!

gábor hojtsy’s picture

Status: Needs review » Needs work

I think it would be best to try by type of fix, eg. info files, make sure the tests still pass, etc.

tmaiochi’s picture

Assigned: Unassigned » tmaiochi

I'll work on that

tmaiochi’s picture

Title: Fix coding standards problems in the module » [META] Fix coding standards problems in the module
Assigned: tmaiochi » Unassigned

Hi @Gábor Hojtsy, I'll create some child issues for this, and change to meta. I'll create one to dependency injection, one for info files, and I'm thinking in create one to documentation and another to coding standards, what do you think?

gábor hojtsy’s picture

Status: Needs work » Active
viniciuscosta’s picture

I can't apply the 3259328-3.patch.

Neeraj333’s picture

Assigned: Unassigned » Neeraj333

I am working on this.

Neeraj333’s picture

Assigned: Neeraj333 » Unassigned
StatusFileSize
new84.23 KB

I have fixed some coding standards errors request you to please verify it.

arti_parmar’s picture

Assigned: Unassigned » arti_parmar
arti_parmar’s picture

Status: Active » Needs review
StatusFileSize
new105.92 KB

I have applied a patch for "[META] Fix coding standards problems in the module", kindly review patch.

gábor hojtsy’s picture

Status: Needs review » Closed (duplicate)

These were fixed in #3459216: Fix all phpcs issues, going to credit you all there and marking this as duplicate.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.